Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feedback] Split Icons into little ESMs #610

Closed
daaku opened this issue May 3, 2021 · 3 comments
Closed

[Feedback] Split Icons into little ESMs #610

daaku opened this issue May 3, 2021 · 3 comments

Comments

@daaku
Copy link

daaku commented May 3, 2021

It would be ideal if each icon were a standalone ESM file. The @primer/components library seems to have taken this approach and it makes tree shaking a deterministic process, and works with stricter dead code elimination (for example currently due to defaultProps every icon may in theory have side effects).

@ashygee ashygee assigned colebemis and unassigned edokoa and ashygee Jun 15, 2021
@colebemis
Copy link
Contributor

This library should be tree-shaking compatible. Is it not working for you?

@daaku
Copy link
Author

daaku commented Sep 2, 2021

Indeed, I was trying to use it with esbuild, which has stricter tree shaking than rollup/wepack. More context here: evanw/esbuild#1241

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2022

Hi! This issue has been marked as stale because it has been open with no activity for 180 days. You can comment on the issue or remove the stale label to keep it open. If you do nothing, this issue will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 1, 2022
@github-actions github-actions bot closed this as completed Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants