Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionList.Item danger variant changes color on hover #4296

Open
jdrush89 opened this issue Feb 21, 2024 · 4 comments
Open

ActionList.Item danger variant changes color on hover #4296

jdrush89 opened this issue Feb 21, 2024 · 4 comments
Assignees
Labels
bug Something isn't working react

Comments

@jdrush89
Copy link
Contributor

Description

It looks like there are conflicting styles on ActionList.Items when using the danger variant. There are two that have the same specificity that change the color of the text on hover, and it seems like the behavior you get depends on which style sheet happens to load first.

Image

Steps to reproduce

Create an ActionList with an ActionList.Item variant="danger"
Hover over the item
Check in the inspector that there are two styles that can possibly change the color if you don't see the color change to default.

Image

Version

v36.9.0

Browser

Chrome

@jdrush89 jdrush89 added the bug Something isn't working label Feb 21, 2024
Copy link
Contributor

Uh oh! @jdrush89, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

@langermank langermank self-assigned this Feb 21, 2024
@langermank
Copy link
Contributor

I'm not able to reproduce this in Storybook, can you link to the code for this specific menu? I see it in production but that item is disabled. Is it meant to be disabled in your screenshot?

@jdrush89
Copy link
Contributor Author

The code is here, it's not doing anything special with the styles. It's not disabled in the screenshot, you can enable the button by sending a message to start a thread.

@broccolinisoup
Copy link
Member

@langermank we moved this to in progress since you assigned it to yourself. Let us know if you have any concern with it 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working react
Projects
None yet
Development

No branches or pull requests

3 participants