Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DialogV2 has incorrect names for width values #4515

Open
iansan5653 opened this issue Apr 19, 2024 · 1 comment
Open

DialogV2 has incorrect names for width values #4515

iansan5653 opened this issue Apr 19, 2024 · 1 comment
Labels
bug Something isn't working component: Dialog react

Comments

@iansan5653
Copy link
Contributor

iansan5653 commented Apr 19, 2024

The new Dialog component has a width prop:

/**
* The width of the dialog.
* small: 296px
* medium: 320px
* large: 480px
* xlarge: 640px
*/
width?: DialogWidth

These size names do not match the Primer overlay primitives.

It should be:

  • xsmall: 192px
  • small: 320px
  • medium: 480px
  • large: 640px
  • xlarge: 960px

Currently the only way to make an actual xlarge dialog is to set the width explicitly via sx.

@broccolinisoup
Copy link
Member

Thanks @iansan5653 for raising this issue. I liked it to the epic (Staff only link) that we do all the dialog work. Let us know if you have any concern with it 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: Dialog react
Projects
None yet
Development

No branches or pull requests

3 participants