Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TreeView] Add area for dragHandle to be shown before the expand/collapse toggle #4542

Closed
ayy-bc opened this issue Apr 29, 2024 · 1 comment · Fixed by #4546
Closed

[TreeView] Add area for dragHandle to be shown before the expand/collapse toggle #4542

ayy-bc opened this issue Apr 29, 2024 · 1 comment · Fixed by #4546
Assignees
@siddharthkp @ayy-bc
Labels
component: TreeView Issues related to the TreeView component react

Comments

@ayy-bc
Copy link
Contributor

ayy-bc commented Apr 29, 2024 •
edited

  • add an area in the grid to add the drag handle (before any other icon/button/component)
  • drag handle should be visible when hovering over the TreeView.Item
  • only take up the space if drag handle is passed from the consumer to tree view
  • when drag handle is passed from consumer, shift child level items to match alignment

https://github.com/github/github/pull/321236/files#diff-785247148fc29c46a71b4de392214511ae6709b4516cc4e921d5e9b37b5a23d3

showing a drag handle in front of Item 1
@github-actions GitHub Actions
Copy link
Contributor

Uh oh! @ayy-bc, the image you shared is missing helpful alt text. Check your issue body.

Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image.

Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.

🤖 Beep boop! This comment was added automatically by github/accessibility-alt-text-bot.

@ayy-bc ayy-bc added the component: TreeView Issues related to the TreeView component label Apr 29, 2024
@ayy-bc ayy-bc mentioned this issue Apr 30, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@siddharthkp siddharthkp

@ayy-bc ayy-bc

Labels
component: TreeView Issues related to the TreeView component react
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add TreeView.LeadingAction sub-component primer/react
2 participants
@siddharthkp @ayy-bc