Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stack justify prop has no effect #4577

Closed
iansan5653 opened this issue May 10, 2024 · 4 comments · Fixed by #4591
Closed

Stack justify prop has no effect #4577

iansan5653 opened this issue May 10, 2024 · 4 comments · Fixed by #4591
Assignees
@joshblack
Labels
bug Something isn't working component: Stack good first issue Good for newcomers react size: sand

Comments

@iansan5653
Copy link
Contributor

Description

Stack accepts a justify prop that is supposed to align with the justify-content CSS property. But setting it has no effect other than setting the data-justify attribute on the HTML element - it doesn't update the CSS.

Steps to reproduce

<Stack justify="space-between">
  <span>a</span>
  <span>b</span>
</Stack>

Version

v36.17.0

Browser

Chrome
@iansan5653 iansan5653 added the bug Something isn't working label May 10, 2024
@joshblack
Copy link
Member

Hmm, seems like we're missing the styles for this responsive prop 🤔 @langermank did we just miss these or were the lost during the transition/renames? 😅

@joshblack joshblack self-assigned this May 14, 2024
@joshblack joshblack mentioned this issue May 14, 2024
Merged
2 tasks
@Adarsha186
Copy link

Hi @iansan5653 , I am looking for some open source projects to work on. If this is issue is still open and hasn't been resolved, I'm interested in contributing to this issue.

@joshblack
Copy link
Member

Hey @Adarsha186! Thanks so much for offering to help! This had a PR open over at #4591 but just wanted to say that if there are any other issues that you're interested in helping out with definitely let us know! We always appreciate the help 🙏

@iansan5653
Copy link
Contributor Author

@Adarsha186 of course we are always happy to accept contributions! Here's a query for unassigned issues with smaller size estimates that may be good candidates: https://github.com/primer/react/issues?q=is%3Aissue%20state%3Aopen%20no%3Aassignee%20label%3A%22size%3A%20sand%22%2C%22size%3A%20pebble%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshblack joshblack

Labels
bug Something isn't working component: Stack good first issue Good for newcomers react size: sand
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Stack): rename spread to justify primer/react
3 participants
@iansan5653 @joshblack @Adarsha186