Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not deploy to repo #365

Open
vednolacni opened this issue Dec 4, 2023 · 16 comments
Open

Could not deploy to repo #365

vednolacni opened this issue Dec 4, 2023 · 16 comments

Comments

@vednolacni
Copy link

vednolacni commented Dec 4, 2023

Like the title. I tried new primo server with new supabase and new github token but still couldnt make it work.

image

@vednolacni
Copy link
Author

image
There is also the problem of selecting old repos... it wont show them.

@mateomorris
Copy link
Collaborator

Weird. Are you sure you have full repo permissions on the token? Are there any error in the console?

@vednolacni
Copy link
Author

vednolacni commented Dec 5, 2023

Weird. Are you sure you have full repo permissions on the token? Are there any error in the console?

Here are my permissions.
image

My browser console when i want to deploy:
image

@vednolacni
Copy link
Author

and today after the update it gives me this:

image

@vednolacni
Copy link
Author

and if i want to download it directly:

image

@rmill2016
Copy link

rmill2016 commented Dec 19, 2023

after
before

I'm running into the same issue, fresh install, one site completed and tried deploying. I'm not able to download or deploy currently. Also, making changes to the primo server doesn't update the site repo, need to delete and recreate for each change...

@mateomorris
Copy link
Collaborator

image There is also the problem of selecting old repos... it wont show them.

This sseems to be a different issue. Are there any console errors?

@mateomorris
Copy link
Collaborator

@vednolacni @rmill2016 those errors seem to be coming from the Blocks - might be worth checking your pages to see if any Blocks are missing data. For example, Cannot read properties of undefined (reading 'alt') means it's trying to compile a Block, but the image field doesn't have a value. You might be able to track it down by clicking the file link.

@mateomorris
Copy link
Collaborator

Also, making changes to the primo server doesn't update the site repo, need to delete and recreate for each change...

@rmill2016 can you elaborate on what you mean?

@rmill2016
Copy link

rmill2016 commented Dec 22, 2023

@mateomorris Hey! Thanks for the headsup, that makes much more sense. I was able to resolve the undefined error and able to download the repository. Although I'm still not able to deploy to a new or existing repo. Primo does, however initialize the repo with a README.md file.
update
update2

@rmill2016
Copy link

rmill2016 commented Dec 22, 2023

I'm investigating the issue further, seems that the POST endpoint for Netlify web host isn't /api/deploy but instead /api/v1/deploy

https://docs.netlify.com/api/get-started/#deploy-with-the-api

@vednolacni Are you perhaps deploying to Netlify as well? Or Vercel?

Edit: It seems after further searching, there was previously an issue with Netlify in the past. Resolved using the file digest method, are you able to confirm Netlify is the issue. I will try to deploy to Vercel now. 👍
Edit 2: Not able to deploy to Vercel either currently.

@Tobarrientos2
Copy link

@rmill2016
I'm experiencing the same problem. I'm unable to deploy to a new repository from Vercel. Have you discovered a solution for this issue?

@mateomorris
Copy link
Collaborator

@rmill2016 note that Primo isn't interacting with Netlify/Vercel's API directly (it used to, but not anymore). The POST shown in your screenshot is your browser building the files and sending them to your server's backend (e.g. myprimoserver.vercel.app/api/deploy), which it has to do since your Github token isn't sent to the browser, so the files generated in the browser need to be sent to the backend to get sent along to Github.

Are you able to create a brand new site & publish it to a repo without issue?

@vednolacni
Copy link
Author

vednolacni commented Jan 3, 2024

I tried crating a new page and a new primo server but still cant deploy any site.

I dont use Netlify or Vercel.

@vednolacni vednolacni reopened this Jan 3, 2024
@mateomorris
Copy link
Collaborator

@vednolacni where are you deploying your Primo server to?

@vednolacni
Copy link
Author

@vednolacni where are you deploying your Primo server to?

cloudflare pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants