Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client extensions - post-release docs improvements part 1 #4150

Closed
3 tasks done
andrew-walford-prisma opened this issue Nov 29, 2022 · 0 comments · Fixed by #4205
Closed
3 tasks done

Client extensions - post-release docs improvements part 1 #4150

andrew-walford-prisma opened this issue Nov 29, 2022 · 0 comments · Fixed by #4205
Assignees
Labels
docs Documentation creation, updates or corrections size: S more than one hour, up to one day
Milestone

Comments

@andrew-walford-prisma
Copy link
Contributor

andrew-walford-prisma commented Nov 29, 2022

There are a few outstanding tasks to resolve that came up in the docs reviews, but we ran out of time to do.

I've tagged this as 4.8.0, but we can merge these changes - when they're done - at any time.

SMEs: Pierre, Serhii

  • Add links to the extensions docs from Middlewares doc. Also, from any others?
  • - Add description of 'Prisma.getExtensionContext'. See here.
  • We need a note in the docs to cover the case where if you call query twice in a row, it executes the query twice. See here. The example, here, I think is misleading. Pierre has opened a PR to fix this specific issue, so I'm ticking this one off.
@andrew-walford-prisma andrew-walford-prisma added this to the 4.8.0 milestone Nov 29, 2022
@andrew-walford-prisma andrew-walford-prisma self-assigned this Nov 29, 2022
@andrew-walford-prisma andrew-walford-prisma added docs Documentation creation, updates or corrections size: S more than one hour, up to one day team: client labels Nov 29, 2022
@andrew-walford-prisma andrew-walford-prisma linked a pull request Dec 7, 2022 that will close this issue
@andrew-walford-prisma andrew-walford-prisma changed the title Client extensions - clear up outstanding issues Client extensions - post-release docs improvements part 1 Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation creation, updates or corrections size: S more than one hour, up to one day
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant