Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check published package sizes #2297

Open
millsp opened this issue Jan 13, 2022 · 7 comments
Open

Check published package sizes #2297

millsp opened this issue Jan 13, 2022 · 7 comments
Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. tech/typescript Issue for tech TypeScript.
Projects
Ecosystem-Tests Issues Categorization

Comments

@millsp
Copy link
Member

millsp commented Jan 13, 2022 •
edited by Jolg42

Write a test that makes sure we don't ship more things than we should. (eg. 42MB engine in SDK)

See https://www.notion.so/prismaio/Check-package-sizes-786e81e4c9c04a3f8443dcd410491775
@millsp millsp added kind/improvement An improvement to existing feature and code. tech/typescript Issue for tech TypeScript. labels Jan 13, 2022
@millsp millsp changed the title Check package sizes Check published package sizes Jan 13, 2022
@janpio
Copy link
Member

janpio commented Jan 13, 2022 •
edited

Note that we have https://prisma.github.io/prisma/dev/bench/ and could potentially add some things in the CI job that creates this.

@Jolg42 Jolg42 added process/candidate team/schema Issue for team Schema. labels Jan 13, 2022
@millsp
Copy link
Member Author

millsp commented Jan 13, 2022 •
edited

I just noticed that this is a duplicate of prisma/prisma#10356. I'll let you @Jolg42 close one of both, depending on which CI you think this issue should be tackled.

@millsp
Copy link
Member Author

millsp commented Jan 14, 2022

FYI: It happened again https://unpkg.com/browse/@prisma/sdk@3.8.0/dist/get-generators/

@janpio
Copy link
Member

janpio commented Jan 14, 2022

"It"?

@millsp
Copy link
Member Author

millsp commented Jan 14, 2022

That we shipped more than we should have, look at that 42MB engine.

@janpio
Copy link
Member

janpio commented Jan 14, 2022

Ahh, that is unexpected :D

Yeah, we should then indeed prioritize that. (And fix it as well)

@janpio janpio added this to New/Additional things to test in Ecosystem-Tests Issues Categorization Apr 8, 2022
@Jolg42 Jolg42 removed their assignment Dec 7, 2022
@Jolg42
Copy link
Member

Jolg42 commented Dec 7, 2022

We recently had to fix @prisma/internals prisma/prisma#16649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. tech/typescript Issue for tech TypeScript.
Projects
Ecosystem-Tests Issues Categorization
New/Additional things to test
Milestone
No milestone
Development

No branches or pull requests
4 participants
@janpio @Jolg42 @floelhoeffel @millsp