Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test #411

Closed
Jolg42 opened this issue Jul 4, 2022 · 6 comments
Closed

Add test #411

Jolg42 opened this issue Jul 4, 2022 · 6 comments
Labels
kind/tech A technical change. team/client Issue for team Client. team/schema Issue for team Schema. tech/typescript Issue for tech TypeScript.

Comments

@Jolg42
Copy link
Member

Jolg42 commented Jul 4, 2022

https://github.com/prisma/engines-wrapper/tree/main/packages/engines-version doesn't have any test

It would be better to have some test, so we can safely merge Renovate PRs like #240

@Jolg42 Jolg42 added tech/typescript Issue for tech TypeScript. team/schema Issue for team Schema. team/client Issue for team Client. kind/tech A technical change. labels Jul 4, 2022
@aqrln
Copy link
Member

aqrln commented Jul 6, 2022

The only code here that has some logic that could be tested and uses external dependencies is now the publish script and not the package itself, as far as I can tell.

@aqrln
Copy link
Member

aqrln commented Jul 6, 2022

(Corollary: whichever contrived test we may add to https://github.com/prisma/engines-wrapper/tree/main/packages/engines-version, it probably won't help us much be able to merge Renovate PRs with confidence since it's not the code that will likely break if something is wrong with the updated dependencies)

@Jolg42
Copy link
Member Author

Jolg42 commented Jul 6, 2022

Indeed, we could have some "dry run mode" for the publish script and test what that does.

@Jolg42
Copy link
Member Author

Jolg42 commented Apr 25, 2023

Since #441 we have a build action which will let us know if TS compilation fails.

@Jolg42
Copy link
Member Author

Jolg42 commented Apr 25, 2023

I made it a dry publish in #442

@Jolg42
Copy link
Member Author

Jolg42 commented Apr 25, 2023

I think we can close this now

@Jolg42 Jolg42 closed this as completed Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/tech A technical change. team/client Issue for team Client. team/schema Issue for team Schema. tech/typescript Issue for tech TypeScript.
Projects
None yet
Development

No branches or pull requests

2 participants