Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename composite types #1135

Closed
janpio opened this issue Apr 25, 2022 · 2 comments · Fixed by #1420
Closed

Rename composite types #1135

janpio opened this issue Apr 25, 2022 · 2 comments · Fixed by #1420
Labels
domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/feature A request for a new feature. tech/typescript Issue for tech TypeScript. topic: composite types topic: mongodb topic: rename LSP rename
Milestone
4.15.0

Comments

@janpio
Copy link
Contributor

janpio commented Apr 25, 2022

Renaming for Composite Types currently does not work.
It should.
@janpio janpio added kind/feature A request for a new feature. topic: mongodb labels Apr 25, 2022
@janpio janpio added this to the 314.0 milestone Apr 25, 2022
@janpio janpio added the process/candidate Candidate for next Milestone. label Apr 25, 2022
@Jolg42 Jolg42 added domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. topic: rename LSP rename labels Apr 27, 2022
@janpio janpio removed the process/candidate Candidate for next Milestone. label Apr 27, 2022
@UltraInstinct05
Copy link
Contributor

Isn't this the same as #1122 in the sense that the solution to that issue is to not disable renaming but rather allow renaming composite types.

@janpio janpio added topic: composite types tech/typescript Issue for tech TypeScript. labels Apr 27, 2022
@janpio
Copy link
Contributor Author

janpio commented Apr 27, 2022

It is, but optimally we will be able to implement this one first and then just close the other one as "not necessary" any more.

@Druue Druue mentioned this issue May 9, 2023
Merged
@Jolg42 Jolg42 modified the milestones: 3.14.0, 4.15.0 May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/feature A request for a new feature. tech/typescript Issue for tech TypeScript. topic: composite types topic: mongodb topic: rename LSP rename
Projects
None yet
Milestone
4.15.0
Development

Successfully merging a pull request may close this issue.

feat(ls): code action to rename views & types prisma/language-tools
3 participants
@janpio @Jolg42 @UltraInstinct05