Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update message for detecting both Stable and Insiders in workspace #1315

Closed
Druue opened this issue Dec 7, 2022 · 0 comments · Fixed by #1324
Closed

Update message for detecting both Stable and Insiders in workspace #1315

Druue opened this issue Dec 7, 2022 · 0 comments · Fixed by #1324
Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. tech/typescript Issue for tech TypeScript. topic: error message topic: Insider topic: vscode
Milestone
4.8.0

Comments

@Druue
Copy link
Contributor

Druue commented Dec 7, 2022

Currently, on detection that a user has both the Stable and Insider versions enabled in their workspace, we emit the following message:

You have both the Insider and stable Prisma VSCode extension installed.
Please uninstall or disable one of them for a better experience.

The language used here should be updated to better reflect VS Code terminology, i.e. "You have both ... enabled" as it's possible that one could have both installed but one is disabled and therefore have no issue.

source: checkForOtherPrismaExtension
@Druue Druue added kind/improvement An improvement to existing feature and code. tech/typescript Issue for tech TypeScript. topic: error message team/schema Issue for team Schema. topic: Insider topic: vscode labels Dec 7, 2022
@Druue Druue mentioned this issue Dec 9, 2022
Merged
@Druue Druue added this to the 4.8.0 milestone Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. tech/typescript Issue for tech TypeScript. topic: error message topic: Insider topic: vscode
Projects
None yet
Milestone
4.8.0
Development

Successfully merging a pull request may close this issue.

Updated wording for Stable & Insiders detection prisma/language-tools
1 participant
@Druue