Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append mention of update to "preview feature not known" error message #1612

Closed
janpio opened this issue Dec 10, 2023 · 1 comment · Fixed by #1627
Closed

Append mention of update to "preview feature not known" error message #1612

janpio opened this issue Dec 10, 2023 · 1 comment · Fixed by #1627
Assignees
@Druue
Labels
domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/improvement An improvement to existing feature and code. tech/typescript Issue for tech TypeScript. topic: diagnostics topic: error message topic: linting
Milestone
5.8.0

Comments

@janpio
Copy link
Contributor

janpio commented Dec 10, 2023

See #1611

Often the "preview feature not known" validation error in VS Code extension is actually caused by a newer CLI being used than the installed extension version. The error message could mention that, saving some confusion.
@Druue Druue self-assigned this Jan 4, 2024
@Druue Druue added kind/improvement An improvement to existing feature and code. domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. topic: diagnostics tech/typescript Issue for tech TypeScript. topic: error message topic: linting labels Jan 4, 2024
@Druue
Copy link
Contributor

Druue commented Jan 4, 2024

So the tricky part here is that this validation error is generated here in engines. That would mean any change here would affect the output in CLI too
image

We could:

  • Find the diagnostic in language-tools and append an extra message like this here
image

Druue added a commit that referenced this issue Jan 4, 2024
@Druue
closes #1612
d7d4ba1
@Druue Druue mentioned this issue Jan 4, 2024
Merged
@Jolg42 Jolg42 added this to the 5.8.0 milestone Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Druue Druue

Labels
domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/improvement An improvement to existing feature and code. tech/typescript Issue for tech TypeScript. topic: diagnostics topic: error message topic: linting
Projects
None yet
Milestone
5.8.0
Development

Successfully merging a pull request may close this issue.

impr(ls): Preview feature not known message prisma/language-tools
3 participants
@janpio @Jolg42 @Druue