Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extension wrongfully suggests Json as a valid type completion on Sqlite #1638

Closed
Druue opened this issue Jan 22, 2024 · 2 comments · Fixed by #1639
Closed

Extension wrongfully suggests Json as a valid type completion on Sqlite #1638

Druue opened this issue Jan 22, 2024 · 2 comments · Fixed by #1639
Assignees
@Druue
Labels
bug/2-confirmed Bug has been reproduced and confirmed. domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/bug A reported bug. tech/typescript Issue for tech TypeScript. topic: autocompletion LSP text document completion
Milestone
5.9.0

Comments

@Druue
Copy link
Contributor

Druue commented Jan 22, 2024 •
edited
Loading

image image

We filter out the Decimal type if we detect a mongodb schema here in types/getSuggestionsForFieldTypes(). There should be another line to detect sqlite and filter out Json
@Druue Druue added kind/bug A reported bug. tech/typescript Issue for tech TypeScript. topic: autocompletion LSP text document completion domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. labels Jan 22, 2024
@janpio
Copy link
Contributor

janpio commented Jan 22, 2024

Now it's a race with prisma/prisma#3786 🐎

@Druue
Copy link
Contributor Author

Druue commented Jan 22, 2024

I already have a local patch to fix the completion lol, but thanks for the link, I'll add it in a comment 😁

@Druue Druue mentioned this issue Jan 22, 2024
Merged
@Jolg42 Jolg42 added the bug/2-confirmed Bug has been reproduced and confirmed. label Jan 23, 2024
@Jolg42 Jolg42 added this to the 5.9.0 milestone Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Druue Druue

Labels
bug/2-confirmed Bug has been reproduced and confirmed. domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/bug A reported bug. tech/typescript Issue for tech TypeScript. topic: autocompletion LSP text document completion
Projects
None yet
Milestone
5.9.0
Development

Successfully merging a pull request may close this issue.

fix: Filter out Json suggestion on SQLite prisma/language-tools
3 participants
@janpio @Jolg42 @Druue