Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run integration tests on an extension release #256

Closed
divyenduz opened this issue Jun 19, 2020 · 4 comments · Fixed by #304
Closed

Run integration tests on an extension release #256

divyenduz opened this issue Jun 19, 2020 · 4 comments · Fixed by #304
Assignees
Labels
kind/improvement An improvement to existing feature and code. topic: automation topic: tests
Milestone

Comments

@divyenduz
Copy link

We run integration tests in the CI just before a release but there can be issues with an extension after the release, if

  • the packaging had an issue
  • it was released manually (i.e. no integration tests)

We can create a GH action that listens to changes in the extension version and runs integration tests (on all platforms #255) after an extension is released.

@divyenduz divyenduz added the kind/improvement An improvement to existing feature and code. label Jun 19, 2020
@carmenberndt
Copy link
Contributor

We can create a GH action in case it was released manually. But if the packaging had an issue, the e2e tests will have to be added to the publish scirpt to get triggered.

@carmenberndt carmenberndt added the process/candidate Candidate for next Milestone. label Jun 23, 2020
@janpio janpio added this to the 2.2.0 milestone Jun 24, 2020
@divyenduz
Copy link
Author

divyenduz commented Jun 25, 2020

Proposal: We can store last tested extension version in a file and run a GH action on schedule that checks that file vs the version actually published and if they do not match, we can run integration tests and on success, we can bump the version in this file.

P.S. We should add this, this would have caught these earlier:

#248
#279

@carmenberndt
Copy link
Contributor

carmenberndt commented Jul 6, 2020

The code command can only be run in case VSCode is installed on the machine. The merged PR can not execute this command. I don't see a way to install VSCode in Mac, Windows and ubuntu from the CLI though.

@janpio
Copy link
Member

janpio commented Jul 6, 2020

Post publish testing moved to https://github.com/prisma/vscode-e2e-tests/issues/2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement An improvement to existing feature and code. topic: automation topic: tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants