New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AutoCompletions show up even without preview feature enabled #816
Comments
Note: Need to figure out how best get the value of the previewFeatures array here, either via the Engine somehow or via a dirty regex on the schema file content. |
Relates to #818 |
Not relevant for This issue is more general - the VSCode extension can not use preview feature flags or (This might be simpler in the future when the Formatter binary is not more but we can use a Webassembly module that provides this functionality, that can rely on the Rust side parsing of the schema file that already exists.) |
ReferentialActions are GA, so this is not a problem anymore. |
The problem itself unfortunately is not fixed by this one feature going GA: There is no way to have auto completions only when specific preview features are enabled. |
We now have a way to filter on previewFeatures flags with https://github.com/prisma/language-tools/blob/main/packages/language-server/src/completion/completions.ts#L337-L366 Added in 9751628 |
This should only show up with
previewFeatures = ["referentialActions"]
in the schema file:Note: referentialActions is now GA so this example is outdated
The text was updated successfully, but these errors were encountered: