Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

referentialActions: No auto complete for available actions #818

Closed
janpio opened this issue Jun 29, 2021 · 5 comments · Fixed by #847
Closed

referentialActions: No auto complete for available actions #818

janpio opened this issue Jun 29, 2021 · 5 comments · Fixed by #847
Assignees
@Jolg42
Labels
bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. team/schema Issue for team Schema. topic: referentialActions topic: vscode
Milestone
2.30.0

Comments

@janpio
Copy link
Member

janpio commented Jun 29, 2021

image
@janpio janpio added bug/1-unconfirmed Bug should have enough information for reproduction, but confirmation has not happened yet. kind/bug A reported bug. process/candidate Candidate for next Milestone. team/schema Issue for team Schema. topic: referentialActions labels Jun 29, 2021
@tomhoule tomhoule removed the process/candidate Candidate for next Milestone. label Jun 30, 2021
@janpio janpio added the process/candidate Candidate for next Milestone. label Jul 1, 2021
@janpio janpio mentioned this issue Jul 1, 2021
Closed
@janpio
Copy link
Member Author

janpio commented Jul 1, 2021 •
edited

I created a PR that adds some tests, that I think would test for what you can see above in the screenshot: #821
Tests are indeed failing.

@janpio janpio mentioned this issue Jul 1, 2021
Closed
3 tasks
@janpio janpio removed the process/candidate Candidate for next Milestone. label Jul 1, 2021
@pantharshit00
Copy link
Contributor

I can confirm this.
image

Looks like completion is only triggered after you type the first letter:
image

@janpio janpio added bug/2-confirmed Bug has been reproduced and confirmed. and removed bug/1-unconfirmed Bug should have enough information for reproduction, but confirmation has not happened yet. labels Jul 1, 2021
@Jolg42 Jolg42 added this to the 2.27.0 milestone Jul 1, 2021
@tomhoule tomhoule removed this from the 2.27.0 milestone Jul 15, 2021
@Jolg42 Jolg42 added the process/candidate Candidate for next Milestone. label Jul 29, 2021
@thebiglabasky thebiglabasky added this to the 2.30.0 milestone Aug 11, 2021
@thebiglabasky thebiglabasky removed the process/candidate Candidate for next Milestone. label Aug 11, 2021
@thebiglabasky
Copy link

We would likely need help from folks like @madebysid or @eemmiillyy here :)

This was referenced Aug 11, 2021
Closed
Closed
@janpio
Copy link
Member Author

janpio commented Aug 13, 2021

Related previous work on adding tests for this: #822 (OrderItemSeven up to OrderItemNine would be the ones for this bug issue)

@janpio
Copy link
Member Author

janpio commented Aug 20, 2021

Note: The autocompletion after the first character only works if you do not have autocompletion window still open from before you types that character. To trigger auto complete, type onDelete: , then type a c, close autocompletion, then trigger it again with Ctrl+Space for example.

@Jolg42 Jolg42 mentioned this issue Aug 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jolg42 Jolg42

Labels
bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. team/schema Issue for team Schema. topic: referentialActions topic: vscode
Projects
None yet
Milestone
2.30.0
Development

Successfully merging a pull request may close this issue.

fix: completion for referentialActions (Cascade,...) prisma/language-tools
5 participants
@janpio @thebiglabasky @Jolg42 @tomhoule @pantharshit00