Skip to content
This repository has been archived by the owner on Jan 14, 2021. It is now read-only.

Print query parameters #504

Closed
timsuchanek opened this issue Feb 19, 2020 · 4 comments
Closed

Print query parameters #504

timsuchanek opened this issue Feb 19, 2020 · 4 comments
Assignees

Comments

@timsuchanek
Copy link
Contributor

As of now, we only print the query when using

new PrismaClient({
  log: ['query']
})

We only print the sql query generated for the js queries. However, we should also print the parameters.

@timsuchanek timsuchanek added the kind/improvement An improvement to existing feature and code. label Feb 19, 2020
@timsuchanek timsuchanek added this to the Preview 23 milestone Feb 19, 2020
@timsuchanek
Copy link
Contributor Author

As this might be a security concern, we first need to decide, if we want to expose the parameters by default.

@janpio janpio added kind/docs A documentation change is required. and removed kind/improvement An improvement to existing feature and code. labels Mar 2, 2020
@janpio janpio assigned nikolasburk and unassigned sorenbs Mar 2, 2020
@nikolasburk
Copy link
Member

The docs needed here are for .on(...) (?), more info will be provided by @timsuchanek.

@timsuchanek
Copy link
Contributor Author

You can find most of the necessary information here in the spec: https://github.com/prisma/specs/tree/master/prisma-client-js#logging

@nikolasburk
Copy link
Member

@nikolasburk nikolasburk reopened this Mar 10, 2020
@nikolasburk nikolasburk removed the kind/docs A documentation change is required. label Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants