This repository has been archived by the owner on Jan 14, 2021. It is now read-only.
Fix downloading HTTPS file with HTTP proxy #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HttpProxyAgent connects to a specified HTTP or HTTPS proxy server for HTTP requests. HttpsProxyAgent connects to a specified HTTP or HTTPS proxy server for HTTPS requests. So we should choose agent based on the destination instead of the proxy URL.
|
|
|
The CLA was signed accidentally (I didn't have a time to review and the web page just told me I have already signed). I am requesting approval from my employer. |
|
CLA confirmed. |
|
Oh, interesting - did we misunderstand how that should work? If so, I think that could explain some of the problems I was having when playing with proxies locally to debug something unrelated. |
janpio
added
bug/1-repro-available
|
Nice catch! Thank you @orzFly for the PR 💯 I randomly found that npm does that too indeed https://github.com/npm/make-fetch-happen/blob/c389a1e567327359aa4b34dbf805989ecbd9755b/agent.js |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HttpProxyAgent connects to a specified HTTP or HTTPS proxy server for HTTP requests.
HttpsProxyAgent connects to a specified HTTP or HTTPS proxy server for HTTPS requests.
So we should choose agent based on the destination instead of the proxy URL.