Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use buildjet action runner where needed #3370

Closed
2 tasks
Jolg42 opened this issue Nov 9, 2022 · 0 comments · Fixed by #3480
Closed
2 tasks

Only use buildjet action runner where needed #3370

Jolg42 opened this issue Nov 9, 2022 · 0 comments · Fixed by #3480
Assignees
Labels
kind/tech A technical change. team/client Issue for team Client. team/schema Issue for team Schema.
Milestone

Comments

@Jolg42
Copy link
Member

Jolg42 commented Nov 9, 2022

We use buildjet runner in multiple actions https://github.com/prisma/prisma-engines/search?q=buildjet

Buildjet is great but we should only use it where it adds value, when it makes tests a lot faster.

Overusing it means that we are more likely to run into concurrency limits which defeats the purpose of making the test faster because instead they will wait for a long time in a queue.

Example situation
https://prisma-company.slack.com/archives/C1FPU5FPT/p1667986934989559
Where a ~3 min long action was waiting for ~1h20
Screenshot 2022-11-09 at 12 18 20
https://github.com/prisma/prisma-engines/actions/runs/3426620655

@Jolg42 Jolg42 added process/candidate kind/tech A technical change. team/schema Issue for team Schema. team/client Issue for team Client. labels Nov 9, 2022
@Jolg42 Jolg42 added this to the 4.8.0 milestone Nov 30, 2022
@pimeys pimeys self-assigned this Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/tech A technical change. team/client Issue for team Client. team/schema Issue for team Schema.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants