Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: @@schema attribute should always be required when schemas is defined in the datasource #3502

Closed
Druue opened this issue Dec 14, 2022 · 0 comments · Fixed by #3503
Closed

Bug: @@schema attribute should always be required when schemas is defined in the datasource #3502

Druue opened this issue Dec 14, 2022 · 0 comments · Fixed by #3503
Assignees
@Druue
Labels
bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. team/schema Issue for team Schema.
Milestone
4.8.0

Comments

@Druue
Copy link
Contributor

Druue commented Dec 14, 2022 •
edited

Per conversation with @pimeys and by proxy @tomhoule
It is currently implemented such that the diagnostic for detecting missing schemas is only pushed if a single model or enum has it. This is not working as intended and should be pushed if no models (or enums for postgres) have it defined.

Pictures for reference

image

image
@Druue Druue added bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. team/schema Issue for team Schema. labels Dec 14, 2022
@Druue Druue added this to the 4.8.0 milestone Dec 14, 2022
@Druue Druue self-assigned this Dec 14, 2022
@Druue Druue mentioned this issue Dec 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Druue Druue

Labels
bug/2-confirmed Bug has been reproduced and confirmed. kind/bug A reported bug. team/schema Issue for team Schema.
Projects
None yet
Milestone
4.8.0
Development

Successfully merging a pull request may close this issue.

fix(psl): Updated validation for multi-schema attribute detection prisma/prisma-engines
1 participant
@Druue