Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Engine: SQL connector must use chunking when a large number of parameters is reached #546

Closed
mavilein opened this issue Mar 3, 2020 · 2 comments
Assignees
Milestone

Comments

@mavilein
Copy link
Member

mavilein commented Mar 3, 2020

Our queries make excessive use of parameters when resolving related records. The databases have different limits for the number of parameters than can be used within a query. We should address this to not fail when retrieving a large number of records.

Tasks:

  • Research how many parameters are accepted for each database.
  • Within the SQL connector use chunking when that limit is execeeded. Maybe the connection function find_many is the only one that is affected.
@mavilein mavilein self-assigned this Mar 3, 2020
@mavilein mavilein modified the milestones: Preview 23, Preview 24 Mar 3, 2020
@dpetrick
Copy link
Contributor

dpetrick commented Mar 3, 2020

Possible alternative: Inline values instead of using parameters. No idea how feasible that is.

@pimeys
Copy link
Contributor

pimeys commented Mar 19, 2020

Solved and merged in #575

@pimeys pimeys closed this as completed Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants