Postgres Default Values #550
Conversation
| // range_tsrange tsrange, | ||
| // range_tstzrange tstzrange, | ||
| // range_daterange daterange | ||
| }); |
There was a problem hiding this comment.
I think I can finish some of these today, I'll send you the PR for review when it's in a mergeable state (it will need quaint changes too).
There was a problem hiding this comment.
Ok, then I'll continue the test with those later on. Most of them are turned into Strings atm anyways, that is why I did not test them.
| @@ -205,16 +205,20 @@ impl SqlSchemaDescriber { | |||
| }; | |||
| let tpe = get_column_type(data_type.as_ref(), &full_data_type, arity, enums); | |||
|
|
|||
| //todo we might want to use regexes here | |||
There was a problem hiding this comment.
yes we could use a regex, but part of it is variable, so they would have to be compiled for every field or (I think I already did that somewhere in the sql-schema-describer) capture the type, then match for the regex and the type capture, which is probably best for performance but also more complicated.
There was a problem hiding this comment.
And sql-schema-describer performance is already good enough™
There was a problem hiding this comment.
Ok, then we'll leave it as is for now.
test them and ensure that we remove the
::typeannotationsFixes prisma/prisma#1704