Index join tables on the B side #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Prisma join tables (for many-to-many relations) only had a unique index on the A columns + B columns, but that could not be used when the relation is queried from the B side. This commit adds an index on the foreign key columns for B.
tomhoule
commented
Mar 6, 2020
|
|
||
| let table = sql::Table { | ||
| name: relation.table_name(), | ||
| columns, | ||
| indices: vec![index], | ||
| indices: indexes, |
pimeys
reviewed
Mar 6, 2020
Comment on lines
-507
to
-527
| #[test] | ||
| #[ignore] | ||
| fn adding_a_many_to_many_relation_for_exotic_id_types_must_work() { | ||
| // TODO: add this once we have figured out what id types we support | ||
| unimplemented!(); | ||
| } | ||
|
|
||
| #[test] | ||
| #[ignore] | ||
| fn forcing_a_relation_table_for_a_one_to_many_relation_must_work() { | ||
| // TODO: implement this once we have decided if this is actually possible in dm v2 | ||
| unimplemented!(); | ||
| } | ||
|
|
||
| // #[test] | ||
| // #[ignore] | ||
| // fn forcing_a_relation_table_for_a_one_to_many_relation_must_work() { | ||
| // // TODO: implement this once we have decided if this is actually possible in dm v2 | ||
| // unimplemented!(); | ||
| // } | ||
|
|
pimeys
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Prisma join tables (for many-to-many relations) only had a
unique index on the A columns + B columns, but that could not be used
when the relation is queried from the B side.
This commit adds an index on the foreign key columns for B.
closes #554