Better way to query with many compound ids #569

pimeys · 2020-03-09T18:20:28Z

Instead of doing

(id1 = 1 AND id2 = 2) OR (id1 = 3 AND id2 = 4)

we do

(id1, id2) IN ((1, 2), (3, 4))

and for SQLite

(id1, id2) IN (VALUES (1, 2), (3, 4))

tomhoule

I'm not very familiar with that code so I may have missed something, but it looks good to me

tomhoule · 2020-03-10T08:15:11Z

libs/prisma-value/src/sql_ext.rs

@@ -15,6 +15,7 @@ impl<'a> From<ParameterizedValue<'a>> for PrismaValue {
            ParameterizedValue::Uuid(uuid) => PrismaValue::Uuid(uuid),
            ParameterizedValue::DateTime(dt) => PrismaValue::DateTime(dt),
            ParameterizedValue::Char(c) => PrismaValue::String(c.to_string()),
+            ParameterizedValue::Bytes(_) => todo!(),


I'll try to get the types mapping PR merged today asap. But afaik this match branch is never reached.

Instead of doing ```sql (id1 = 1 AND id2 = 2) OR (id1 = 3 AND id2 = 4) ``` we do ```sql (id1, id2) IN ((1, 2), (3, 4)) ``` and for SQLite ```sql (id1, id2) IN (VALUES (1, 2), (3, 4)) ```

pimeys requested review from dpetrick and tomhoule March 9, 2020 18:20

pimeys added this to the Preview 24 New milestone Mar 9, 2020

pimeys self-assigned this Mar 9, 2020

pimeys force-pushed the tuple-in-selection branch from e5da66d to 5fe9cbf Compare March 9, 2020 20:57

tomhoule approved these changes Mar 10, 2020

View reviewed changes

pimeys force-pushed the tuple-in-selection branch from 5fe9cbf to 1f5c0ff Compare March 10, 2020 09:45

pimeys mentioned this pull request Mar 10, 2020

QE: Optimize the compound id select #570

Closed

pimeys force-pushed the tuple-in-selection branch from 1f5c0ff to a7e2ac8 Compare March 10, 2020 09:57

dpetrick approved these changes Mar 10, 2020

View reviewed changes

Better way to query with many compound ids

a863d3b

Instead of doing ```sql (id1 = 1 AND id2 = 2) OR (id1 = 3 AND id2 = 4) ``` we do ```sql (id1, id2) IN ((1, 2), (3, 4)) ``` and for SQLite ```sql (id1, id2) IN (VALUES (1, 2), (3, 4)) ```

pimeys force-pushed the tuple-in-selection branch from a7e2ac8 to a863d3b Compare March 11, 2020 11:22

pimeys merged commit 7f34f22 into master Mar 11, 2020

pimeys deleted the tuple-in-selection branch March 11, 2020 13:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better way to query with many compound ids #569

Better way to query with many compound ids #569

pimeys commented Mar 9, 2020

tomhoule left a comment

tomhoule Mar 10, 2020

Better way to query with many compound ids #569

Better way to query with many compound ids #569

Conversation

pimeys commented Mar 9, 2020

tomhoule left a comment

Choose a reason for hiding this comment

tomhoule Mar 10, 2020

Choose a reason for hiding this comment