Adjust legacy M:N Relation Inference #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhoule
approved these changes
Mar 20, 2020
| && table.indices.len() >= 1 | ||
| && table.indices.last().unwrap().columns.len() == 2 | ||
| && table.indices.last().unwrap().tpe == IndexType::Unique | ||
| table.columns.len() == 2 && table.indices.len() >= 2 && shared(table) |
There was a problem hiding this comment.
could there be more indices on these tables?
There was a problem hiding this comment.
I wanted to leave this open in case people have sth like this:
Index(A)
Index(B)
Primary(A,B)
I am not aware of us doing it like this, but I wanted to leave that flexibility.
| .find(|column| column.name.to_lowercase() == "b") | ||
| .is_some() | ||
| && table.indices.len() >= 2 | ||
| && table.columns.iter().any(|c| c.name == "id".to_string()) |
There was a problem hiding this comment.
nitpick: here I think you can avoid an allocation by changing c.name to c.name.as_str() and removing to_string().
| && shared(table) | ||
| } | ||
|
|
||
| fn shared(table: &Table) -> bool { |
There was a problem hiding this comment.
nitpick also, but I think the name could be a bit more descriptive, maybe shared_match_prisma_join_table
There was a problem hiding this comment.
Good point, I adjusted it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes prisma/prisma#1885