Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify dml error handling #609

Merged
merged 1 commit into from Mar 23, 2020
Merged

Unify dml error handling #609

merged 1 commit into from Mar 23, 2020

Conversation

pimeys
Copy link
Contributor

@pimeys pimeys commented Mar 23, 2020

Now we get the Datamodel and Configuration directly from the PrismaOpts.

@pimeys pimeys self-assigned this Mar 23, 2020
@pimeys pimeys added kind/improvement An improvement to existing feature and code. tech/engines/query engine Issue in the Query Engine labels Mar 23, 2020
@pimeys pimeys added this to the Preview 25 milestone Mar 23, 2020
@pimeys pimeys force-pushed the unify-dml-error-handling branch 3 times, most recently from 8bca9ef to fe392f6 Compare March 23, 2020 12:35
tomhoule
tomhoule approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't seen anything bad code-wise, but I haven't thought very hard about the backward-compatibility of the CLI. If it's manually tested I think it's ok!

@pimeys
Copy link
Contributor Author

pimeys commented Mar 23, 2020

Yep. This has been tested with the prisma2 integration test suite also...

@pimeys pimeys merged commit 45bc4bb into master Mar 23, 2020
@pimeys pimeys deleted the unify-dml-error-handling branch March 23, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhoule tomhoule tomhoule approved these changes

@mavilein mavilein Awaiting requested review from mavilein

Assignees

@pimeys pimeys

Labels
kind/improvement An improvement to existing feature and code. tech/engines/query engine Issue in the Query Engine
Projects
None yet
Milestone
Preview 25
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pimeys @tomhoule