New relations in the migration engine #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomhoule
commented
Mar 24, 2020
| }) | ||
| .collect() | ||
| Ok((model, table)) | ||
| }) |
There was a problem hiding this comment.
This is an indentation change.
tomhoule
commented
Mar 24, 2020
| assert_eq!(row["string"].as_str().unwrap(), "test_string"); | ||
|
|
||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
These two tests are now obsolete (no implicit defaults anymore).
tomhoule
force-pushed
the
migration-engine/new-relations
branch
from
906922e
to
f700954
Compare
tomhoule
changed the title
tomhoule
changed the title
do4gr
reviewed
Mar 24, 2020
| @@ -1 +1,2 @@ | |||
| edition = "2018" | |||
| max_width = 120 | |||
There was a problem hiding this comment.
I changed that because rust-analyzer wasn't respecting the limit in rustfmt.toml (we have two of these, need to figure out why).
do4gr
reviewed
Mar 24, 2020
| auto_increment: { | ||
| match f.default_value() { | ||
| Some(DefaultValue::Expression(ValueGenerator { | ||
| name: _, |
There was a problem hiding this comment.
yes most definitely, we can even simplify this whole match to a matches! call. I'll do that.
There was a problem hiding this comment.
Simplified to matches!(f.default_value(), Some(DefaultValue::Expression(ValueGenerator { generator: ValueGeneratorFn::Autoincrement, .. })))
tomhoule
force-pushed
the
migration-engine/new-relations
branch
from
f700954
to
a10ba5f
Compare
Also two improvements: - The implicit defaults have been removed - DateTime @default(now()) now sets a proper database default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.