Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Health check fixes #614

Merged
merged 1 commit into from Mar 25, 2020
Merged

Health check fixes #614

merged 1 commit into from Mar 25, 2020

Conversation

pimeys
Copy link
Contributor

@pimeys pimeys commented Mar 25, 2020

This should address several things:

  • Testing the connection taken from the pool with SELECT 1 every 15 seconds (not every time)
  • Properly handling dead connections in the pool so the system can stay healthy if the database dies and goes back up during a normal operation.
  • If connection is idling for too long, we'll kick it out and reconnect. For now the timer is for five minutes of inactivity.

Addresses:

@pimeys pimeys self-assigned this Mar 25, 2020
@pimeys pimeys added tech/engines/query engine Issue in the Query Engine kind/improvement An improvement to existing feature and code. labels Mar 25, 2020
@pimeys pimeys added this to the Preview 25 milestone Mar 25, 2020
@pimeys pimeys merged commit 3c1162d into master Mar 25, 2020
@pimeys pimeys deleted the health-check-fixes branch March 25, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pimeys pimeys

Labels
kind/improvement An improvement to existing feature and code. tech/engines/query engine Issue in the Query Engine
Projects
None yet
Milestone
Preview 25
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@pimeys