Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the pool constraints in QE #616

Merged
merged 1 commit into from Mar 26, 2020
Merged

Set the pool constraints in QE #616

merged 1 commit into from Mar 26, 2020

Conversation

pimeys
Copy link
Contributor

@pimeys pimeys commented Mar 26, 2020

A change in Quaint where we create the pool by using a Builder. Now we need to set certain constraints in QE.

@pimeys pimeys added kind/improvement An improvement to existing feature and code. tech/engines/query engine Issue in the Query Engine labels Mar 26, 2020
@pimeys pimeys added this to the Preview 25 milestone Mar 26, 2020
@pimeys pimeys requested a review from tomhoule March 26, 2020 10:28
@pimeys pimeys self-assigned this Mar 26, 2020
tomhoule
tomhoule approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@pimeys pimeys merged commit 3870076 into master Mar 26, 2020
@pimeys pimeys deleted the pool-builder branch March 26, 2020 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhoule tomhoule tomhoule approved these changes

Assignees

@pimeys pimeys

Labels
kind/improvement An improvement to existing feature and code. tech/engines/query engine Issue in the Query Engine
Projects
None yet
Milestone
Preview 25
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pimeys @tomhoule