Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid relying on JSON database migrations backwards compatibility #741

Closed
tomhoule opened this issue May 12, 2020 · 0 comments · Fixed by #805
Closed

Avoid relying on JSON database migrations backwards compatibility #741

tomhoule opened this issue May 12, 2020 · 0 comments · Fixed by #805
Assignees
@tomhoule
Labels
kind/improvement An improvement to existing feature and code. tech/engines/migration engine Issue in the Migration Engine tech/engines Issue for tech Engines. tech/typescript Issue for tech TypeScript.
Milestone
2.1.0

Comments

@tomhoule
Copy link
Contributor

tomhoule commented May 12, 2020 •
edited

We deserialize these steps in

  • listMigrations
  • unapplyMigrations

In both cases we can avoid fallible deserialization.
@tomhoule tomhoule added the tech/engines/migration engine Issue in the Migration Engine label May 12, 2020
@tomhoule tomhoule self-assigned this May 12, 2020
@janpio janpio added this to the Beta 6 milestone May 12, 2020
@janpio janpio modified the milestones: Beta 6, Beta 7, Beta 8 May 26, 2020
@janpio janpio added tech/engines Issue for tech Engines. tech/typescript Issue for tech TypeScript. kind/improvement An improvement to existing feature and code. labels Jun 11, 2020
@janpio janpio modified the milestones: Beta 10, 2.1.0 Jun 11, 2020
@tomhoule tomhoule mentioned this issue Jun 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomhoule tomhoule

Labels
kind/improvement An improvement to existing feature and code. tech/engines/migration engine Issue in the Migration Engine tech/engines Issue for tech Engines. tech/typescript Issue for tech TypeScript.
Projects
None yet
Milestone
2.1.0
Development

Successfully merging a pull request may close this issue.

Make migration engine resilient to old database migration steps prisma/prisma-engines
3 participants
@janpio @mavilein @tomhoule