Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mask Datasource URLs in all artifacts generated by the Migration Engine #840

Closed
mavilein opened this issue Jun 23, 2020 · 1 comment · Fixed by #843
Closed

Mask Datasource URLs in all artifacts generated by the Migration Engine #840

mavilein opened this issue Jun 23, 2020 · 1 comment · Fixed by #843
Assignees
@mavilein @tomhoule
Labels
kind/bug A reported bug. tech/engines/migration engine Issue in the Migration Engine
Milestone
2.2.0

Comments

@mavilein
Copy link
Member

Datasource URLs are stored in clear text in the steps.json. That means a hardcoded URL will be part of users source code repositories.
We should make sure that other places like generated Readmes etc. are fixed by this as well. (I think simply fixing the diffing process should be fine.)

Relates to: prisma/migrate#310
@mavilein mavilein added process/candidate kind/bug A reported bug. tech/engines/migration engine Issue in the Migration Engine labels Jun 23, 2020
mavilein added a commit that referenced this issue Jun 24, 2020
@mavilein
fix #840
3106520
@mavilein mavilein mentioned this issue Jun 24, 2020
Merged
@mavilein mavilein added this to the 2.2.0 milestone Jun 24, 2020
@mavilein
Copy link
Member Author

fixed in: 43a04d7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mavilein mavilein

@tomhoule tomhoule

Labels
kind/bug A reported bug. tech/engines/migration engine Issue in the Migration Engine
Projects
None yet
Milestone
2.2.0
Development

Successfully merging a pull request may close this issue.

[Patch 2.1.x] add masking for datasource URLs prisma/prisma-engines
3 participants
@janpio @mavilein @tomhoule