New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A generator provider should accept arbitrary commands #1101
Labels
Milestone
Comments
pantharshit00
added
kind/feature
A request for a new feature.
topic: schema
topic: cli
labels
Dec 11, 2019
This is related to #934. Is there any progress on either of them? |
steebchen
added a commit
that referenced
this issue
Mar 25, 2020
only show the JS example when generator is prisma-client-js fix #1101
Jolg42
added a commit
that referenced
this issue
Mar 26, 2020
* feat(prisma2/cli): allow arbitrary generator commands with flags only show the JS example when generator is prisma-client-js fix #1101 * Add comments Co-authored-by: Joël Galeran <Jolg42@users.noreply.github.com>
Thanks 👍 |
@robojones You're welcome, and yes it's quite weird 🙃🤣 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This fails on the latest alpha:
It seems this is the line where the error happens:
We should also add a test which covers this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Generators can be any executable file, but currently this is limited to one single command, which means you can't provide any arguments to a generator:
Providing arguments doesn't work:
Instead, the
provider
should accept full commands with arguments.For example,
provider
could accept specifying full commands:An alternative would be an array to specify the command with arguments:
The text was updated successfully, but these errors were encountered: