Skip to content

CockroachDB: use idiomatic native types #12237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #12385
tomhoule opened this issue Mar 10, 2022 · 0 comments · Fixed by prisma/prisma-engines#2866
Closed
Tracked by #12385

CockroachDB: use idiomatic native types #12237

tomhoule opened this issue Mar 10, 2022 · 0 comments · Fixed by prisma/prisma-engines#2866
Labels
domain/psl Issue in the "PSL" domain: Prisma Schema Language domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/improvement An improvement to existing feature and code. tech/engines/datamodel Issue about parsing/validation/rendering of the Prisma schema topic: cockroachdb topic: schema
Milestone
3.13.0

Comments

@tomhoule
Copy link
Contributor

tomhoule commented Mar 10, 2022 •
edited
Loading

The question is whether we want to stay close to postgres or use the idiomatic cockroachdb names for the types. Example: string types https://www.cockroachlabs.com/docs/v21.2/string#related-types

My suggestion is to do a complete overhaul to adhere to the crdb recommendations.

Related issues:
@tomhoule tomhoule added process/candidate topic: schema tech/engines/datamodel Issue about parsing/validation/rendering of the Prisma schema domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. topic: cockroachdb domain/psl Issue in the "PSL" domain: Prisma Schema Language labels Mar 10, 2022
@janpio janpio added the kind/improvement An improvement to existing feature and code. label Mar 11, 2022
@tomhoule tomhoule mentioned this issue Mar 16, 2022
Closed
32 tasks
@Jolg42 Jolg42 added this to the 3.12.0 milestone Mar 16, 2022
@janpio janpio modified the milestones: 3.12.0, 3.13.0 Apr 11, 2022
This was referenced Apr 22, 2022
Closed
Merged
@janpio janpio mentioned this issue Apr 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain/psl Issue in the "PSL" domain: Prisma Schema Language domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/improvement An improvement to existing feature and code. tech/engines/datamodel Issue about parsing/validation/rendering of the Prisma schema topic: cockroachdb topic: schema
Projects
None yet
Milestone
3.13.0
Development

Successfully merging a pull request may close this issue.

Implement new native types definition on cockroachdb prisma/prisma-engines
4 participants
@janpio @Jolg42 @floelhoeffel @tomhoule