Add `@prisma/prisma-fmt-wasm` to CLI and output dependency version in `-v`, use instead of Formatter Engine binary #12496

janpio · 2022-03-23T19:58:12Z

@prisma/prisma-fmt-wasm exists and can replace the Formatter Engine binary usage in Prisma CLI already.

Add @prisma/prisma-fmt-wasm as dependency (requires CI changes)
Output dependency package version in -v output of Prisma CLI
Replace the format (and others) call of the Formatter Engine binary with a call to the Wasm module (in a separate PR)
Test CLI Engine Crash Reporting along the way to make sure it also works properly with the Wasm module
Profit 🚢

The text was updated successfully, but these errors were encountered:

jkomyno · 2022-06-17T14:53:35Z

Note: currently, installing @prisma/prisma-fmt-wasm in prisma CLI would fail because of these lines in prisma_fmt_build.js:

//                                     .---> this isn't compatible with a monorepo
//                                     |
//                                 ^^^^^^^^
const path = require('path').join(__dirname, 'prisma_fmt_build_bg.wasm');
const bytes = require('fs').readFileSync(path);

const wasmModule = new WebAssembly.Module(bytes);
const wasmInstance = new WebAssembly.Instance(wasmModule, imports);
wasm = wasmInstance.exports;
module.exports.__wasm = wasm;

The error I get at runtime is:

node:internal/fs/utils:345
    throw err;
    ^

Error: ENOENT: no such file or directory, open '/Users/jkomyno/work/prisma/prisma/packages/cli/build/prisma_fmt_build_bg.wasm'
    at Object.openSync (node:fs:591:3)
    at Object.readFileSync (node:fs:459:35)
    at ../../node_modules/.pnpm/@prisma+prisma-fmt-wasm@3.16.0-24.e7e033759b8d20a2a51df5d48adb60b11c6ee4fc/node_modules/@prisma/prisma-fmt-wasm/src/prisma_fmt_build.js (/Users/jkomyno/work/prisma/prisma/packages/cli/build/index.js:58593:31)
    at __require (/Users/jkomyno/work/prisma/prisma/packages/cli/build/index.js:13:50)
    at Object.<anonymous> (/Users/jkomyno/work/prisma/prisma/packages/cli/build/index.js:96233:38)
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Module._load (node:internal/modules/cjs/loader:827:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12) {
  errno: -2,
  syscall: 'open',
  code: 'ENOENT',
  path: '/Users/jkomyno/work/prisma/prisma/packages/cli/build/prisma_fmt_build_bg.wasm'
}

Node.js v18.3.0

prisma_fmt_build_bg.wasm is indeed installed into another folder: node_modules/.pnpm/@prisma+prisma-fmt-wasm@3.16.0-23.5a802ae8a39d1977852fc20e30a13566e06671cd/node_modules/@prisma/prisma-fmt-wasm/src/prisma_fmt_build_bg.wasm

jkomyno · 2022-06-17T15:00:38Z

About extracting the version of @prisma/prisma-fmt-wasm to display in prisma --version, let's remind ourselves about this issue: prisma/prisma-engines#3302

janpio · 2022-06-18T11:42:50Z

Note: currently, installing @prisma/prisma-fmt-wasm in prisma CLI would fail because of these lines in prisma_fmt_build.js:

Something to work on with @tomhoule.

About extracting the version of @prisma/prisma-fmt-wasm to display in prisma --version, let's remind ourselves about this issue: prisma/prisma-engines#3302

We can either implement that, or maybe use the Npm package version as an adequate replacement if that has enough information.

tomhoule · 2022-06-20T09:24:11Z

Note: currently, installing @prisma/prisma-fmt-wasm in prisma CLI would fail because of these lines in prisma_fmt_build.js:

This part I don't understand, I don't see what is wrong.

edit to add details: this is generated code (from wasm-bindgen), so changing is possible but not very practical.

tomhoule · 2022-06-20T09:24:36Z

For the version, we can implement something easily, if that's what we want. The package.json approach might be better, I don't know how JS projects do it usually.

janpio · 2022-06-20T14:25:32Z

The issue here asks for the dependency version, so the issue @jkomyno linked to is technically not relevant unless there is a good reason not to do it that way.

jkomyno · 2022-06-21T13:27:06Z

@Jolg42 suggests that we might fix the path issue following a similar approach to https://github.com/prisma/prisma/blob/main/helpers/compile/plugins/replaceWithPlugin.ts#L44

I will try to add it to the plugins option of the applyCjsDefaults function in build.ts

0gust1 · 2022-10-18T10:50:38Z

We have the same kind of error as @jkomyno posted, when trying to run prisma migrate deploy on our target server.

node: 16.14.2
prisma: 4.4.0
env: Azure AppService ("classic" zip deploy)

Error: ENOENT: no such file or directory, open '/home/site/wwwroot/node_modules/.bin/prisma_fmt_build_bg.wasm'
    at Object.openSync (node:fs:585:3)
    at Object.readFileSync (node:fs:453:35)
    at ../../node_modules/.pnpm/@prisma+prisma-fmt-wasm@4.4.0-66.f352a33b70356f46311da8b00d83386dd9f145d6/node_modules/@prisma/prisma-fmt-wasm/src/prisma_fmt_build.js (/home/site/wwwroot/node_modules/.bin/prisma:12337:31)
    at __require (/home/site/wwwroot/node_modules/.bin/prisma:14:50)
    at Object.<anonymous> (/home/site/wwwroot/node_modules/.bin/prisma:86202:38)
    at Module._compile (node:internal/modules/cjs/loader:1103:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1157:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12) {
  errno: -2,
  syscall: 'open',
  code: 'ENOENT',
  path: '/home/site/wwwroot/node_modules/.bin/prisma_fmt_build_bg.wasm'
}

In node_modules/@prisma/engines we have the correct engines (prisma-fmt-debian-openssl-1.1.x in our case), but it keep searching for a wasm module, at the wrong place (node_modules/.bin/prisma_fmt_build_bg.wasm).
Everything works fine in a local development context.

jkomyno · 2022-10-19T09:30:07Z

@0gust1 would you please report here what's your prisma version full output? Even though we're still shipping the formatter engine (prisma-fmt-debian-openssl-1.1.x), we've been using a WebAssembly module for prisma format for a few releases now. It'd be also awesome if you could provide more information about your project structure.
Is it a standalone project or a monorepo? Would you please have a minimally reproducible project we could look at to better understand/reproduce the issue?

By the way, I'm tracking this potential Wasm bundling problem here.

0gust1 · 2022-10-19T10:03:48Z

@jkomyno Hi 👋 . Thanks for the follow-up! I'll open an issue (it was on my today's TODO, after my yesterday post on #15859) and/or post on #15881. Expect some news in the next 6 hours.

Very quickly (those elements – and others – will be in the issue):
It's a standalone project; I suspect that the azure deployment could "do things" to the node_modules folder; I still can't completely rule out a problem on our own workflow. Reproductibility won't be easy (as it will need an Azure account/subscription), but I'll try.

jkomyno · 2022-10-19T10:50:01Z

@0gust1 that's great, thanks for the quick response! Please report that information directly in #15881, so we can keep track of the potential issue in a single place and keep things nice and tidy ☺️

looppin · 2023-03-07T08:58:27Z

i am using Azure app services and i solved this problem as bellow;

update npm version npm install npm@latest -g
install again prisma with npm npm i prisma

note: make sure you are in the main folder (like /home/site/wwwroot).

janpio added topic: cli topic: prisma version CLI: prisma version or -v topic: prisma format CLI: prisma format kind/tech A technical change. team/schema Issue for team Schema. topic: wasm labels Mar 23, 2022

janpio mentioned this issue Mar 23, 2022

Prototype WebAssembly Engine in Prisma CLI #8626

Open

janpio added the tech/typescript Issue for tech TypeScript. label Mar 23, 2022

janpio assigned tomhoule Apr 1, 2022

janpio assigned jkomyno Jun 11, 2022

jkomyno mentioned this issue Jul 25, 2022

feat(cli): add fmt wasm #14450

Closed

5 tasks

jkomyno mentioned this issue Aug 11, 2022

feat(cli): add @prisma/prisma-fmt-wasm to version command #14760

Merged

6 tasks

Jolg42 added this to the 4.3.0 milestone Aug 17, 2022

jkomyno closed this as completed in #14760 Aug 19, 2022

0gust1 mentioned this issue Oct 18, 2022

Run migrations by code #13549

Open

jkomyno mentioned this issue Oct 19, 2022

Reproduce potential Wasm bundling issue on prisma migrate deploy #15881

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `@prisma/prisma-fmt-wasm` to CLI and output dependency version in `-v`, use instead of Formatter Engine binary #12496

Add `@prisma/prisma-fmt-wasm` to CLI and output dependency version in `-v`, use instead of Formatter Engine binary #12496

janpio commented Mar 23, 2022 •

edited by jkomyno

jkomyno commented Jun 17, 2022 •

edited

jkomyno commented Jun 17, 2022

janpio commented Jun 18, 2022

tomhoule commented Jun 20, 2022 •

edited

tomhoule commented Jun 20, 2022

janpio commented Jun 20, 2022

jkomyno commented Jun 21, 2022 •

edited

0gust1 commented Oct 18, 2022 •

edited

jkomyno commented Oct 19, 2022 •

edited

0gust1 commented Oct 19, 2022 •

edited

jkomyno commented Oct 19, 2022

looppin commented Mar 7, 2023

Add @prisma/prisma-fmt-wasm to CLI and output dependency version in -v, use instead of Formatter Engine binary #12496

Add @prisma/prisma-fmt-wasm to CLI and output dependency version in -v, use instead of Formatter Engine binary #12496

Comments

janpio commented Mar 23, 2022 • edited by jkomyno

jkomyno commented Jun 17, 2022 • edited

jkomyno commented Jun 17, 2022

janpio commented Jun 18, 2022

tomhoule commented Jun 20, 2022 • edited

tomhoule commented Jun 20, 2022

janpio commented Jun 20, 2022

jkomyno commented Jun 21, 2022 • edited

0gust1 commented Oct 18, 2022 • edited

jkomyno commented Oct 19, 2022 • edited

0gust1 commented Oct 19, 2022 • edited

jkomyno commented Oct 19, 2022

looppin commented Mar 7, 2023

Add `@prisma/prisma-fmt-wasm` to CLI and output dependency version in `-v`, use instead of Formatter Engine binary #12496

Add `@prisma/prisma-fmt-wasm` to CLI and output dependency version in `-v`, use instead of Formatter Engine binary #12496

janpio commented Mar 23, 2022 •

edited by jkomyno

jkomyno commented Jun 17, 2022 •

edited

tomhoule commented Jun 20, 2022 •

edited

jkomyno commented Jun 21, 2022 •

edited

0gust1 commented Oct 18, 2022 •

edited

jkomyno commented Oct 19, 2022 •

edited

0gust1 commented Oct 19, 2022 •

edited