Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI support in prisma forks #13775

Closed
jkomyno opened this issue Jun 13, 2022 · 1 comment · Fixed by #13788
Closed

Fix CI support in prisma forks #13775

jkomyno opened this issue Jun 13, 2022 · 1 comment · Fixed by #13788
Assignees
@jkomyno
Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. topic: ci/cd topic: internal
Milestone
4.0.0

Comments

@jkomyno
Copy link
Contributor

jkomyno commented Jun 13, 2022

Our CI currently relies on logging in to Dockerhub via the docker/login-action@v2 action, in order to be granted higher docker pull rate limits.
To do so, we set up the DOCKER_USERNAME and DOCKER_PASSWORD secrets in the prisma/prisma repository. However, Github secrets in a repo DO NOT propagate when a user forks such repository.

Solutions

  • We could try to log in via docker/login-action@v2 only if both the DOCKER_USERNAME and DOCKER_PASSWORD secrets are set up (preferred)
  • We could scope the action so that it only triggers in the prisma/prisma repository
@jkomyno
Copy link
Contributor Author

jkomyno commented Jun 13, 2022

Related note: buildjet runners might not be available to the forks by default.

@jkomyno jkomyno self-assigned this Jun 13, 2022
@Jolg42 Jolg42 added kind/improvement An improvement to existing feature and code. topic: internal topic: ci/cd team/schema Issue for team Schema. labels Jun 13, 2022
@danstarns danstarns mentioned this issue Jun 13, 2022
Merged
@Jolg42 Jolg42 added this to the 4.0.x milestone Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkomyno jkomyno

Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. topic: ci/cd topic: internal
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

fix: skip docker login if no docker secrets are found danstarns/prisma
2 participants
@Jolg42 @jkomyno