Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poor grammar and confusing language in Prisma CLI #13925

Closed
givensuman opened this issue Jun 21, 2022 · 1 comment · Fixed by #13926
Closed

Poor grammar and confusing language in Prisma CLI #13925

givensuman opened this issue Jun 21, 2022 · 1 comment · Fixed by #13926
Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema.
Milestone

Comments

@givensuman
Copy link
Contributor

Bug description

The particular message I'm talking about happens when you run prisma init in a project with a .gitignore already in it. It says:

warn You already have a .gitignore. Don't forget to exclude .env to not commit any secret.

The language in not commit any secret is poor in grammar, and the usage of the word exclude is confusing.

How to reproduce

  1. mkdir prismaissue
  2. cd prismaissue
  3. touch .gitignore
  4. npx prisma init

Expected behavior

I would suggest changing the prompt to:

warn You already have a .gitignore. Don't forget to include .env in it to not commit any private information.

Prisma information

Environment & setup

  • OS: Windows
  • Database: N/A
  • Node.js version: 14.17.6

Prisma Version

Environment variables loaded from .env
prisma                  : 3.15.2
@prisma/client          : 3.15.2
Current platform        : windows
Query Engine (Node-API) : libquery-engine 461d6a05159055555eb7dfb337c9fb271cbd4d7e (at node_modules\@prisma\engines\query_engine-windows.dll.node)
Migration Engine        : migration-engine-cli 461d6a05159055555eb7dfb337c9fb271cbd4d7e (at node_modules\@prisma\engines\migration-engine-windows.exe)
Introspection Engine    : introspection-core 461d6a05159055555eb7dfb337c9fb271cbd4d7e (at node_modules\@prisma\engines\introspection-engine-windows.exe)
Format Binary           : prisma-fmt 461d6a05159055555eb7dfb337c9fb271cbd4d7e (at node_modules\@prisma\engines\prisma-fmt-windows.exe)
Default Engines Hash    : 461d6a05159055555eb7dfb337c9fb271cbd4d7e
Studio                  : 0.462.0

@givensuman givensuman added the kind/bug A reported bug. label Jun 21, 2022
@Jolg42 Jolg42 added this to the 4.0.x milestone Jun 21, 2022
@matthewmueller matthewmueller added team/schema Issue for team Schema. kind/improvement An improvement to existing feature and code. and removed kind/bug A reported bug. labels Jun 21, 2022
@matthewmueller
Copy link
Contributor

Thanks for the PR @givensuman!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants