Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename 'getVersion' to 'getEngineVersion' in @prisma/internals #14055

Closed
jkomyno opened this issue Jun 29, 2022 · 0 comments · Fixed by #14054
Closed

Rename 'getVersion' to 'getEngineVersion' in @prisma/internals #14055

jkomyno opened this issue Jun 29, 2022 · 0 comments · Fixed by #14054
Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. topic: internal
Milestone
4.1.0

Comments

@jkomyno
Copy link
Contributor

jkomyno commented Jun 29, 2022

The currently getVersion name is ambiguous. getEngineVersion actually reveals the intent (retrieve the hash version from Rust engines).
@jkomyno jkomyno added kind/improvement An improvement to existing feature and code. topic: internal team/schema Issue for team Schema. labels Jun 29, 2022
@jkomyno jkomyno mentioned this issue Jun 29, 2022
Merged
@jkomyno jkomyno added this to the 4.1.0 milestone Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. topic: internal
Projects
None yet
Milestone
4.1.0
Development

Successfully merging a pull request may close this issue.

chore(internals): rename getVersion to getEngineVersion prisma/prisma
1 participant
@jkomyno