Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema: add deprecation warning for datasource property referentialIntegrity (renamed to relationMode) #15689

Closed
Jolg42 opened this issue Oct 6, 2022 · 1 comment · Fixed by prisma/prisma-engines#3449
Closed

Schema: add deprecation warning for datasource property referentialIntegrity (renamed to relationMode) #15689

Jolg42 opened this issue Oct 6, 2022 · 1 comment · Fixed by prisma/prisma-engines#3449
Assignees
@jkomyno
Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. topic: referentialIntegrity/relationMode topic: schema validation topic: schema
Milestone
4.7.0

Comments

@Jolg42
Copy link
Member

Jolg42 commented Oct 6, 2022

Problem

We renamed the datasource property referentialIntegrity to relationMode (first appearance will be in 4.5.0)

Suggested solution

We might want to drop the datasource property referentialIntegrity in a next major version, adding a deprecation message would help.
@Jolg42 Jolg42 mentioned this issue Oct 11, 2022
Closed
@jkomyno jkomyno mentioned this issue Oct 26, 2022
Merged
@jkomyno
Copy link
Contributor

jkomyno commented Nov 14, 2022

Note: we plan on using warnings for this, but first we have to figure out how Prisma itself supports warnings.

@janpio janpio changed the title Schema: add deprecation message for datasource property referentialIntegrity (renamed to relationMode) Schema: add deprecation warningfor datasource property referentialIntegrity (renamed to relationMode) Nov 23, 2022
@Jolg42 Jolg42 changed the title Schema: add deprecation warningfor datasource property referentialIntegrity (renamed to relationMode) Schema: add deprecation warning for datasource property referentialIntegrity (renamed to relationMode) Nov 24, 2022
@jkomyno jkomyno mentioned this issue Nov 27, 2022
Merged
@janpio janpio added this to the 4.7.0 milestone Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkomyno jkomyno

Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. topic: referentialIntegrity/relationMode topic: schema validation topic: schema
Projects
None yet
Milestone
4.7.0
Development

Successfully merging a pull request may close this issue.

feat(psl): add deprecation warning for the "referentialIntegrity" attribute prisma/prisma-engines
3 participants
@janpio @Jolg42 @jkomyno