Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prisma Client: Add tests for orderByNulls preview feature for MongoDB #17100

Closed
Jolg42 opened this issue Jan 2, 2023 · 3 comments
Closed

Prisma Client: Add tests for orderByNulls preview feature for MongoDB #17100

Jolg42 opened this issue Jan 2, 2023 · 3 comments
Labels
kind/improvement An improvement to existing feature and code. team/client Issue for team Client. topic: mongodb topic: orderByNulls `{ sort: 'asc', nulls: 'last' }` and similar topic: previewFeatures Issue touches on an preview feature flag topic: prisma-client topic: tests

Comments

@Jolg42
Copy link
Member

Jolg42 commented Jan 2, 2023

While checking #17081

I didn't find any tests in prisma/prisma running on MongoDB
Currently, the following databases are tested

    {
      provider: 'sqlite',
    },
    {
      provider: 'postgresql',
    },
    {
      provider: 'mysql',
    },
    {
      provider: 'sqlserver',
    },
    {
      provider: 'cockroachdb',
    },

https://github.com/prisma/prisma/tree/main/packages/client/tests/functional/order-by-null

@Jolg42 Jolg42 added kind/improvement An improvement to existing feature and code. topic: prisma-client topic: tests topic: previewFeatures Issue touches on an preview feature flag team/client Issue for team Client. topic: mongodb topic: orderByNulls `{ sort: 'asc', nulls: 'last' }` and similar labels Jan 2, 2023
@SevInf
Copy link
Contributor

SevInf commented Jan 2, 2023

@Weakky
Copy link
Member

Weakky commented May 25, 2023

image

It is in the docs (might have been updated since you linked it). MongoDB is intentionally not supported yet because supporting the feature required too many hacks. The connector doesn't have the capability and thus doesn't expose the API at all. We could review that in the future but I'd suggest we keep it that way for now.

EDIT: Yeah, it didn't mention MongoDB at first #16728 (comment)

@Weakky Weakky closed this as completed May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement An improvement to existing feature and code. team/client Issue for team Client. topic: mongodb topic: orderByNulls `{ sort: 'asc', nulls: 'last' }` and similar topic: previewFeatures Issue touches on an preview feature flag topic: prisma-client topic: tests
Projects
None yet
Development

No branches or pull requests

3 participants