Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow for renaming fields in client #2033

Closed
jhalborg opened this issue Apr 1, 2020 · 1 comment
Closed

Workflow for renaming fields in client #2033

jhalborg opened this issue Apr 1, 2020 · 1 comment
Labels
kind/improvement An improvement to existing feature and code. topic: re-introspection

Comments

@jhalborg
Copy link

jhalborg commented Apr 1, 2020

Problem

Congrats on the beta release! 馃帀

I saw the videos on YouTube, and have a question.

Here (https://youtu.be/NK2p6WNs7EY?t=74) and here (https://youtu.be/IEg68UqgNBA?t=37), the narrator manually updates and then re-updates the field names for relations between two models, which will be reflected in the client API. This is great to be able to do, and I'd gladly do it once - but is this the finished workflow, meaning that you'll have to redo these changes every time you update your schema and hence client?

Solution

To be able to provide names for specific fields once, and not have to do it again ever regardless of the number of introspections/generations of the client.

@schickling schickling self-assigned this Apr 1, 2020
@pantharshit00 pantharshit00 added the kind/improvement An improvement to existing feature and code. label Apr 1, 2020
@janpio
Copy link
Member

janpio commented May 25, 2020

Hey, we will indeed implement something that keeps these changes if possible across Introspection runs: #2503 We call this "Re-Introspection" and will implement all kinds of details to hopefully make this awesome: topic: re-introspection

I will close this issue now as the other one explicitly tracks the solution we are thinking of 馃殌

@janpio janpio closed this as completed May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement An improvement to existing feature and code. topic: re-introspection
Projects
None yet
Development

No branches or pull requests

4 participants