Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output notice about Prisma1->Prisma2 upgrade documentation and tool #2555

Closed
3 tasks done
janpio opened this issue May 25, 2020 · 9 comments
Closed
3 tasks done

Output notice about Prisma1->Prisma2 upgrade documentation and tool #2555

janpio opened this issue May 25, 2020 · 9 comments
Assignees
Labels
kind/improvement An improvement to existing feature and code. tech/typescript Issue for tech TypeScript. topic: prisma db pull CLI: prisma db pull
Milestone

Comments

@janpio
Copy link
Member

janpio commented May 25, 2020

After Introspection we want to output some text (TBD) that links to our Prisma1->Prisma2 upgrade documentation. This should be triggered by #2424 (and only be shown on Prisma1 and Prisma11).

  • Define text that should be shown to users
  • Define where the text will be shown to users
  • Combine both for implementation
@janpio janpio added process/candidate tech/typescript Issue for tech TypeScript. labels May 25, 2020
@janpio janpio added this to the Beta 7 milestone May 25, 2020
@timsuchanek
Copy link
Contributor

timsuchanek commented May 26, 2020

Define where the text will be shown to users

We can show this at the end of our introspection command.

@Jolg42
Copy link
Member

Jolg42 commented May 26, 2020

image

Maybe at the end

This database was created from Prisma 1.
If you wish yo upgrade to Prisma 2 you can read the documentation here.

With link on read the documentation here

@janpio janpio added kind/improvement An improvement to existing feature and code. and removed process/candidate labels May 26, 2020
@nikolasburk
Copy link
Member

nikolasburk commented May 26, 2020

I'd suggest the following output:

The database you introspected seems to belong to a Prisma 1 project.
If you want to upgrade to Prisma 2.0, please visit the docs here: 
https://pris.ly/upgrading-to-prisma2

@janpio
Copy link
Member Author

janpio commented May 26, 2020

(We might iterate on the details of the text a bit more tomorrow, but this can already be implemented so we can start testing it.)

@Jolg42
Copy link
Member

Jolg42 commented May 27, 2020

So I didn't remove the "(NonPrisma)" output yet, I guess I can now? (The message will only show for Prisma1 or Prisma11 values but my quick test was to fake it 😄)

This is the new look with latest alpha 2.0.0-alpha.1252:
Screen Shot 2020-05-27 at 10 14 10

And --print
Screen Shot 2020-05-27 at 10 21 50

@Jolg42
Copy link
Member

Jolg42 commented May 27, 2020

New output tested on Prisma 1 db
Screen Shot 2020-05-27 at 12 09 12
--print
Screen Shot 2020-05-27 at 12 12 26

@Jolg42

This comment has been minimized.

@Jolg42
Copy link
Member

Jolg42 commented May 27, 2020

Screen Shot 2020-05-27 at 14 42 29

@Jolg42
Copy link
Member

Jolg42 commented May 27, 2020

It's in 2.0.0-alpha.1255

@Jolg42 Jolg42 closed this as completed May 27, 2020
@janpio janpio added topic: prisma db pull CLI: prisma db pull and removed topic: prisma introspect labels Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement An improvement to existing feature and code. tech/typescript Issue for tech TypeScript. topic: prisma db pull CLI: prisma db pull
Projects
None yet
Development

No branches or pull requests

4 participants