Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration to disable update check and message #2595

Closed
steebchen opened this issue May 28, 2020 · 2 comments · Fixed by #2769
Closed

Configuration to disable update check and message #2595

steebchen opened this issue May 28, 2020 · 2 comments · Fixed by #2769
Assignees
Labels
kind/improvement An improvement to existing feature and code. tech/typescript Issue for tech TypeScript. topic: update-notifier
Milestone

Comments

@steebchen
Copy link
Contributor

image

It should be possible to disable this update check, preferably using an environment variable.

@janpio janpio added kind/improvement An improvement to existing feature and code. topic: update-notifier labels May 28, 2020
@steebchen steebchen changed the title Disable update check Disable update check and message May 28, 2020
@janpio
Copy link
Member

janpio commented May 28, 2020

Is there a common ENV var naming pattern for this maybe?

I am aware of this very specific example FASTLANE_SKIP_UPDATE_CHECK: http://docs.fastlane.tools/advanced/fastlane/#skip-update-check-when-launching-fastlane

@janpio janpio changed the title Disable update check and message Configuration to disable update check and message Jun 2, 2020
@janpio janpio added the tech/typescript Issue for tech TypeScript. label Jun 10, 2020
@janpio janpio added this to the 2.1.0 milestone Jun 10, 2020
@matthewmueller
Copy link
Contributor

matthewmueller commented Jun 15, 2020

This issue is about still wanting telemetry, but just removing the update message.

The easiest would be providing an environment variable that doesn't print out that message.

This would require a change here:

if (checkResult.status === 'ok' && checkResult.data.outdated) {
console.error(
drawBox({
height: 4,
width: 59,
str: `\n${chalk.blue('Update available')} ${packageJson.version} -> ${
checkResult.data.current_version
}\nRun ${chalk.bold(checkResult.data.install_command)} to update`,
horizontalPadding: 2,
}),
)
}

The name of this environment variable should be prefixed with CHECKPOINT_: https://github.com/prisma/checkpoint-client#environment-variables

@steebchen steebchen self-assigned this Jun 15, 2020
@steebchen steebchen linked a pull request Jun 16, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement An improvement to existing feature and code. tech/typescript Issue for tech TypeScript. topic: update-notifier
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants