Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename pinnedPlatform to pinnedBinaryTarget #2644

Closed
divyenduz opened this issue Jun 2, 2020 · 2 comments · Fixed by #2661
Closed

Rename pinnedPlatform to pinnedBinaryTarget #2644

divyenduz opened this issue Jun 2, 2020 · 2 comments · Fixed by #2661
Assignees
@Jolg42
Labels
kind/improvement An improvement to existing feature and code. tech/typescript Issue for tech TypeScript. topic: schema
Milestone
Beta 9

Comments

@divyenduz
Copy link
Contributor

pinnedPlatform is a field on the generator block in Prisma schema file. We made a decision to rename it to pinnedBinaryTarget.

Decision: https://prisma-company.slack.com/archives/CEYCG2MCN/p1566475959421300
Spec PR: prisma/specs#474
@divyenduz divyenduz added kind/improvement An improvement to existing feature and code. topic: schema process/candidate labels Jun 2, 2020
@Jolg42 Jolg42 self-assigned this Jun 4, 2020
@Jolg42 Jolg42 added this to the Beta 9 milestone Jun 4, 2020
@Jolg42 Jolg42 added tech/typescript Issue for tech TypeScript. and removed process/candidate labels Jun 4, 2020
@Jolg42
Copy link
Member

Jolg42 commented Jun 4, 2020 •
edited

We have this error message for info

prisma/src/packages/sdk/src/getGenerators.ts

Line 322 in ead9e6b

`The \`pinnedPlatform\` field on the generator definition is deprecated.

Should we have the same for pinnedBinaryTarget?

@divyenduz
Copy link
Contributor Author

divyenduz commented Jun 4, 2020 •
edited

Yes, any instance of the following should be renamed

platforms -> binaryTargets
pinnedPlatform -> pinnedBinaryTarget

Update: we discussed this further in chat and this message is because pinnedPlatform was deprecated because of the rename. This message can stay as is.

Jolg42 added a commit that referenced this issue Jun 4, 2020
@Jolg42
chore(sdk,engine-core): rename pinnedPlatform to pinnedBinaryTargets
3e0cfbc 
Related #2644
@Jolg42 Jolg42 mentioned this issue Jun 4, 2020
Merged
@Jolg42 Jolg42 linked a pull request Jun 4, 2020 that will close this issue
chore(sdk,engine-core): rename pinnedPlatform to pinnedBinaryTargets #2661
Merged
@janpio janpio modified the milestones: Beta 9, New Beta 9 Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jolg42 Jolg42

Labels
kind/improvement An improvement to existing feature and code. tech/typescript Issue for tech TypeScript. topic: schema
Projects
None yet
Milestone
Beta 9
Development

Successfully merging a pull request may close this issue.

chore(sdk,engine-core): rename pinnedPlatform to pinnedBinaryTargets prisma/prisma
3 participants
@janpio @divyenduz @Jolg42