Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@prisma/engine-core forces users to enable esModuleInterop #2681

Closed
jasonkuhrt opened this issue Jun 6, 2020 · 2 comments
Closed

@prisma/engine-core forces users to enable esModuleInterop #2681

jasonkuhrt opened this issue Jun 6, 2020 · 2 comments
Assignees
Labels
bug/1-unconfirmed Bug should have enough information for reproduction, but confirmation has not happened yet. kind/bug A reported bug. tech/typescript Issue for tech TypeScript.
Milestone

Comments

@jasonkuhrt
Copy link
Member

jasonkuhrt commented Jun 6, 2020

Bug description

Consumers of @prisma/client @prisma/sdk beta 8 need to have their tsconfig setup with esModuleInterop: true OR skipLibCheck: true. This was not the case in beta 4.

The source of the issue is not @prisma/client @prisma/sdk but rather @prisma/engine-core.

In the screenshot below the code . part is when I go enable esModuleInterop in the project.

image

How to reproduce

You can repro on this branch graphql-nexus/nexus-plugin-prisma#137. I have not spent the effort to make a minimal repro yet sorry!

Expected behavior

As a consumer of @prisma/client @prisma/sdk I expect a modern experience which in part means not being the source of requiring my project to flip the esModuleInterop flag in my tsconfig setting.

Prisma information

Its a tsconfig thing

Environment & setup

  • OS:
  • Database:
  • Prisma version:
  • Node.js version:

Don't think this matters.

@jasonkuhrt jasonkuhrt added the bug/1-unconfirmed Bug should have enough information for reproduction, but confirmation has not happened yet. label Jun 6, 2020
@Jolg42 Jolg42 added the tech/typescript Issue for tech TypeScript. label Jun 8, 2020
@timsuchanek timsuchanek self-assigned this Jun 8, 2020
@janpio janpio added the kind/bug A reported bug. label Jun 8, 2020
@Jolg42 Jolg42 added this to the Beta 9 milestone Jun 8, 2020
@timsuchanek
Copy link
Contributor

Thanks a lot for reporting 🙏
This issue is fixed in the latest alpha version of @prisma/cli.
You can try it out with npm i -g @prisma/cli@alpha.

In case it’s not fixed for you - please let us know and we’ll reopen this issue!

@jasonkuhrt
Copy link
Member Author

Thanks @timsuchanek! As discussed offline, the issue is consumption of @prisma/sdk, not @prisma/client.

@janpio janpio modified the milestones: Beta 9, New Beta 9 Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/1-unconfirmed Bug should have enough information for reproduction, but confirmation has not happened yet. kind/bug A reported bug. tech/typescript Issue for tech TypeScript.
Projects
None yet
Development

No branches or pull requests

4 participants