Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Pipeline: Release stable release from chosen dev instead from current master state #2724

Closed
janpio opened this issue Jun 11, 2020 · 1 comment
Closed

CI Pipeline: Release stable release from chosen dev instead from current master state #2724

janpio opened this issue Jun 11, 2020 · 1 comment
Assignees
@timsuchanek
Labels
kind/improvement An improvement to existing feature and code. tech/typescript Issue for tech TypeScript. topic: ci/cd
Milestone
2.1.0

Comments

@janpio
Copy link
Member

janpio commented Jun 11, 2020 •
edited

Right now a release is done from master which is accidentally also the latest dev - but it might not always be e.g. in the case when we have a broken version etc. what we want is that the release script just takes the exact dev version that should be turned into a real release.
@janpio janpio added kind/improvement An improvement to existing feature and code. topic: ci/cd labels Jun 11, 2020
@janpio janpio added this to the 2.1.0 milestone Jun 11, 2020
@janpio janpio added the tech/typescript Issue for tech TypeScript. label Jun 12, 2020
@timsuchanek
Copy link
Contributor

This is implemented in the latest pipeline and has already been used for 2.0.1.
We set the env var RELEASE_PROMOTE_DEV to accomplish this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timsuchanek timsuchanek

Labels
kind/improvement An improvement to existing feature and code. tech/typescript Issue for tech TypeScript. topic: ci/cd
Projects
None yet
Milestone
2.1.0
Development

No branches or pull requests
2 participants
@janpio @timsuchanek