Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove microsoftSqlServer preview flag #4537

Closed
Tracked by #8628
matthewmueller opened this issue Dec 7, 2020 · 8 comments · Fixed by #8943
Closed
Tracked by #8628

Remove microsoftSqlServer preview flag #4537

matthewmueller opened this issue Dec 7, 2020 · 8 comments · Fixed by #8943
Assignees
@Jolg42
Labels
kind/feature A request for a new feature. team/client Issue for team Client. team/schema Issue for team Schema. topic: sql server Microsoft SQL Server
Milestone
2.31.0 / 3.0.x

Comments

@matthewmueller
Copy link
Contributor

Collect issues related to microsoftSqlServer and see if we can remove the preview feature flag.

Introduced in 2.11.0.

Related Issue: #4039
@matthewmueller matthewmueller added team/client Issue for team Client. team/schema Issue for team Schema. topic: sql server Microsoft SQL Server process/candidate labels Dec 7, 2020
@pimeys pimeys self-assigned this Dec 9, 2020
@mavilein
Copy link
Member

mavilein commented Dec 10, 2020 •
edited

I think the following issues should be addressed before we can stabilize SQL Server:

@pimeys

This comment has been minimized.

Sign in to view
@janpio janpio added kind/feature A request for a new feature. and removed status/needs-action labels Apr 12, 2021
@tomhoule

This comment has been minimized.

Sign in to view
@matthewmueller

This comment has been minimized.

Sign in to view
@janpio
Copy link
Member

janpio commented Jul 1, 2021

Also related when we remove the preview flag: prisma/docs#1957

@matthewmueller matthewmueller mentioned this issue Aug 6, 2021
Closed
50 tasks
@millsp millsp self-assigned this Aug 13, 2021
@matthewmueller matthewmueller assigned pimeys and Weakky and unassigned millsp Aug 24, 2021
@matthewmueller matthewmueller added this to the 2.31.0 / 3.0.x milestone Aug 24, 2021
@pimeys
Copy link
Contributor

pimeys commented Aug 25, 2021

Engines side done in prisma/prisma-engines#2183

Jolg42 added a commit that referenced this issue Aug 26, 2021
@Jolg42
chore: remove microsoftSqlServer flag
6020d68 
Closes #4537
@Jolg42 Jolg42 mentioned this issue Aug 26, 2021
Merged
@pimeys pimeys assigned Jolg42 and unassigned pimeys and Weakky Aug 26, 2021
@pimeys
Copy link
Contributor

pimeys commented Aug 26, 2021

Pushing this to @Jolg42 who can check the client side or assign somebody to check the client side.

@Jolg42
Copy link
Member

Jolg42 commented Aug 27, 2021

Already a PR open, waiting for a review #8943

Jolg42 added a commit that referenced this issue Aug 27, 2021
@Jolg42
chore: remove microsoftSqlServer flag (GA) (#8943)
56ffcb6 
* chore: remove microsoftSqlServer flag

Closes #4537

* test: update snapshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jolg42 Jolg42

Labels
kind/feature A request for a new feature. team/client Issue for team Client. team/schema Issue for team Schema. topic: sql server Microsoft SQL Server
Projects
None yet
Milestone
2.31.0 / 3.0.x
Development

Successfully merging a pull request may close this issue.

chore: remove microsoftSqlServer flag (GA) prisma/prisma
8 participants
@pimeys @matthewmueller @janpio @Jolg42 @mavilein @tomhoule @millsp @Weakky