Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent errors with different commands #8013

Closed
pimeys opened this issue Jul 2, 2021 · 3 comments · Fixed by #9512
Closed

Inconsistent errors with different commands #8013

pimeys opened this issue Jul 2, 2021 · 3 comments · Fixed by #9512
Assignees
@Jolg42
Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. tech/engines/introspection engine Issue in the Introspection Engine tech/engines/migration engine Issue in the Migration Engine tech/typescript Issue for tech TypeScript. topic: error topic: migrate
Milestone
3.2.0

Comments

@pimeys
Copy link
Contributor

pimeys commented Jul 2, 2021

Bug description

The error output differs in color and pacing with different migration and introspection commands.
2021-07-02_15-07-1625233718

  • db pull is completely red.
  • db push has the Error: in red, other text in white. Missing whitespace after the Datasource.
  • db migrate dev is like db push, but has whitespace after the Datasource.

How to reproduce

npx prisma db pull
npx prisma db push
npx prisma migrate dev

Expected behavior

Some consistency would be great here.

Prisma information

Environment & setup

Every OS in the world.

Prisma Version

2.26.0
@pimeys pimeys added kind/bug A reported bug. tech/engines/migration engine Issue in the Migration Engine tech/engines/introspection engine Issue in the Introspection Engine labels Jul 2, 2021
@pimeys
Copy link
Contributor Author

pimeys commented Jul 2, 2021

2021-07-02_15-07-1625234360

moar

@janpio janpio added topic: error team/schema Issue for team Schema. labels Jul 2, 2021
@pantharshit00
Copy link
Contributor

I can reproduce this.

image

@pantharshit00 pantharshit00 added kind/improvement An improvement to existing feature and code. and removed kind/bug A reported bug. labels Jul 26, 2021
@Jolg42 Jolg42 added process/candidate tech/typescript Issue for tech TypeScript. labels Jul 29, 2021
@tomhoule tomhoule added this to the 2.31.0 / 3.0.x milestone Aug 25, 2021
@tomhoule tomhoule modified the milestones: 2.31.0 / 3.0.x, 3.1.0 Sep 10, 2021
@tomhoule tomhoule modified the milestones: 3.1.0, 3.2.0 Sep 22, 2021
@Jolg42 Jolg42 self-assigned this Sep 29, 2021
Jolg42 added a commit that referenced this issue Sep 29, 2021
@Jolg42
fix(migrate): error coloring
0dd77e2 
Closes #8013
@Jolg42 Jolg42 mentioned this issue Sep 29, 2021
Merged
@Jolg42
Copy link
Member

Jolg42 commented Sep 29, 2021

Fun fact, mongodb error comes from engine (similar one is in TS as well)
https://github.com/prisma/prisma-engines/blob/master/introspection-engine/core/src/rpc.rs#L80

With PR looks like
Screen Shot 2021-09-29 at 14 43 08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jolg42 Jolg42

Labels
kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. tech/engines/introspection engine Issue in the Introspection Engine tech/engines/migration engine Issue in the Migration Engine tech/typescript Issue for tech TypeScript. topic: error topic: migrate
Projects
None yet
Milestone
3.2.0
Development

Successfully merging a pull request may close this issue.

fix(migrate): error coloring prisma/prisma
5 participants
@pimeys @janpio @Jolg42 @tomhoule @pantharshit00