Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db seed tests need to run on multiple platforms, not just Ubuntu #8033

Closed
Tracked by #8628
, #8732
...
janpio opened this issue Jul 2, 2021 · 2 comments
Closed
Tracked by #8628
, #8732
...

db seed tests need to run on multiple platforms, not just Ubuntu #8033

janpio opened this issue Jul 2, 2021 · 2 comments
Assignees
@Jolg42
Labels
kind/feature A request for a new feature. team/schema Issue for team Schema. topic: prisma db seed CLI: prisma db seed
Milestone
2.31.0 / 3.0.x

Comments

@janpio
Copy link
Member

janpio commented Jul 2, 2021

As we know db seed has specific problems on specific platforms, hence it needs to be tested on all platforms. This should not be to big of a deal, as it does not actually talk to databases and so can be extracted from the current test suite in GH Actions and be run on all platforms.
@janpio janpio added kind/feature A request for a new feature. team/schema Issue for team Schema. topic: seeding topic: prisma db seed CLI: prisma db seed and removed topic: seeding labels Jul 2, 2021
@Jolg42
Copy link
Member

Jolg42 commented Aug 13, 2021

WIP in #8037

@Jolg42 Jolg42 mentioned this issue Aug 13, 2021
Closed
7 tasks
@Jolg42 Jolg42 added this to the 2.31.0 / 3.0.x milestone Aug 13, 2021
@Jolg42 Jolg42 mentioned this issue Aug 20, 2021
Closed
50 tasks
@Jolg42 Jolg42 self-assigned this Sep 3, 2021
@Jolg42
Copy link
Member

Jolg42 commented Sep 6, 2021

Since multi-os testing was added to e2e prisma/ecosystem-tests#1806

This is not as relevant as before especially if only testing db seed it would not bring more confidence at the tradeoff of more test jobs running

So basically closing as duplicate of #7725 for now

@Jolg42 Jolg42 closed this as completed Sep 6, 2021
@Jolg42 Jolg42 mentioned this issue Sep 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jolg42 Jolg42

Labels
kind/feature A request for a new feature. team/schema Issue for team Schema. topic: prisma db seed CLI: prisma db seed
Projects
None yet
Milestone
2.31.0 / 3.0.x
Development

No branches or pull requests
2 participants
@janpio @Jolg42