Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drift detection makes CLI output where bold #8063

Closed
janpio opened this issue Jul 4, 2021 · 4 comments · Fixed by #9514
Closed

Drift detection makes CLI output where bold #8063

janpio opened this issue Jul 4, 2021 · 4 comments · Fixed by #9514
Labels
good first issue Always wanted to get involved in an open source project but don’t know where to begin? Welcome! kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. tech/typescript Issue for tech TypeScript. topic: cli topic: drift topic: migrate topic: prisma dev CLI: prisma dev (removed) topic: prisma migrate dev CLI: prisma migrate dev
Milestone

Comments

@janpio
Copy link
Member

janpio commented Jul 4, 2021

image

Intended that the full output is bolded?

@tomhoule tomhoule added team/schema Issue for team Schema. tech/typescript Issue for tech TypeScript. topic: cli topic: prisma dev CLI: prisma dev (removed) topic: cli-migrate topic: migrate topic: prisma migrate dev CLI: prisma migrate dev labels Jul 5, 2021
@tomhoule
Copy link
Contributor

tomhoule commented Jul 5, 2021

That's a question for @Jolg42 — I like the attention drawing bold font for dev diagnostics personally, but I don't know if it's intentional.

@Jolg42
Copy link
Member

Jolg42 commented Jul 6, 2021

The bold text here is from devDiagnostic.action.reason
Screen Shot 2021-07-06 at 17 50 23

It's printed as part of the prompt here

const message = `${reason}

From what I see the bold comes from passing the text to the "prompts" lib which adds bold to all the text passed.

So not intended I think. We could print the reason independently as console.info and then do the prompt.

@janpio
Copy link
Member Author

janpio commented Jul 9, 2021

Similar is true for the reset:
image

@pantharshit00 pantharshit00 added the kind/improvement An improvement to existing feature and code. label Jul 11, 2021
@Jolg42 Jolg42 added the good first issue Always wanted to get involved in an open source project but don’t know where to begin? Welcome! label Jul 12, 2021
@rubiagatra
Copy link
Contributor

Let me help with this one, already made the PR at #9329

@Jolg42 Jolg42 added this to the 3.2.0 milestone Sep 29, 2021
@Jolg42 Jolg42 linked a pull request Sep 29, 2021 that will close this issue
@Jolg42 Jolg42 closed this as completed Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Always wanted to get involved in an open source project but don’t know where to begin? Welcome! kind/improvement An improvement to existing feature and code. team/schema Issue for team Schema. tech/typescript Issue for tech TypeScript. topic: cli topic: drift topic: migrate topic: prisma dev CLI: prisma dev (removed) topic: prisma migrate dev CLI: prisma migrate dev
Projects
None yet
6 participants