Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Mongo is not yet supported" in databaseTypeToConnectorType() #8261

Closed
timleslie opened this issue Jul 14, 2021 · 2 comments · Fixed by #8555
Closed

"Mongo is not yet supported" in databaseTypeToConnectorType() #8261

timleslie opened this issue Jul 14, 2021 · 2 comments · Fixed by #8555
Assignees
@Jolg42
Labels
kind/improvement An improvement to existing feature and code. team/client Issue for team Client. topic: mongodb
Milestone
2.29.0

Comments

@timleslie
Copy link

Bug description

When calling createDatabase from @prisma/sdk we get the error Mongo is not yet supported, which comes from

prisma/src/packages/sdk/src/convertCredentials.ts

Line 198 in d367426

throw new Error(`Mongo is not yet supported`)

This is preventing us from using the migrations SDK in Keystone.

How to reproduce

The failure can be seen happening here: https://github.com/keystonejs/keystone/runs/3062577041?check_suite_focus=true

Expected behavior

The @prisma/sdk package should support MongoDB.

Prisma information

Environment & setup

  • OS:
  • Database:
  • Node.js version:

Prisma Version

2.27.0
@timleslie timleslie added the kind/bug A reported bug. label Jul 14, 2021
This was referenced Jul 14, 2021
Closed
Closed
@matthewmueller matthewmueller added kind/improvement An improvement to existing feature and code. team/client Issue for team Client. topic: mongodb and removed kind/bug A reported bug. labels Jul 14, 2021
@felixbuchholz
Copy link

Just wanted to leave a note of support. Would be spectacular if Keystone could use the MongoDB connector! :)
Also do not completely understand why an error would be thrown, when the connector is already in preview mode.

Jolg42 added a commit that referenced this issue Aug 3, 2021
@Jolg42
chore(sdk): remove useless function databaseTypeToConnectorType
ded93bc 
Closes #8261
@Jolg42 Jolg42 mentioned this issue Aug 3, 2021
Merged
@Jolg42 Jolg42 added this to the 2.29.0 milestone Aug 3, 2021
@Jolg42 Jolg42 self-assigned this Aug 3, 2021
Jolg42 added a commit that referenced this issue Aug 4, 2021
@Jolg42
chore(sdk): remove useless function databaseTypeToConnectorType (#8555)
dc71f9b 
Closes #8261
@Jolg42
Copy link
Member

Jolg42 commented Aug 4, 2021

You can try our dev version (not recommended for production) 2.29.0-dev.25 @timleslie @felixbuchholz 😉

It will part of the 2.29.0 planned for Tuesday.

Andrew-Colman pushed a commit to Andrew-Colman/prisma that referenced this issue Aug 7, 2021
@Jolg42 @Andrew-Colman
chore(sdk): remove useless function databaseTypeToConnectorType (pris…
a69bff8 
…ma#8555)

Closes prisma#8261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jolg42 Jolg42

Labels
kind/improvement An improvement to existing feature and code. team/client Issue for team Client. topic: mongodb
Projects
None yet
Milestone
2.29.0
Development

Successfully merging a pull request may close this issue.

chore(sdk): remove useless function databaseTypeToConnectorType prisma/prisma
5 participants
@matthewmueller @thebiglabasky @timleslie @Jolg42 @felixbuchholz